Hi Libing,
Thank you for the review.
Libing Song wrote:
> Hi Alfranio,
>
> Nice work, but a problem need to be clarified.
>
> The option --ignore-causality introduces an another problem in SBM.
> The following statements will cause a inconsistency between master and
> slave.
>
> CREATE TABLE t1(c1 INTEGER) ENGINE=Innodb;
> CREATE TABLE t2(c1 INTEGER) ENGINE=MyISAM;
> BEGIN ;
> INSERT INTO t1 VALUES (1),(2);
> INSERT INTO t2 SELECT * FROM t1;
> COMMIT;
>
> so, I think that locking the N_table before starting a transaction is
> better.
I don't think we should do this but if you want to discuss this option
I can elaborate my opinion against this idea.
> Maybe It is difficult to implement, however give users a advice is easy.
I agree with you. I think we should print a warning message in such case.
>
> I propose --ignore-causality is a session variable which can be changed
> at runtime,
> if it has to be used.
> this will reduce the option's influence.
I agree with you.
Cheers.
