List:Commits« Previous MessageNext Message »
From:Charles Bell Date:November 13 2009 7:07pm
Subject:Re: bzr commit into mysql-6.0-backup branch (ritheesh.vedire:2890)
Bug#47540
View as plain text  
STATUS
------
Approved pending changes.

REQUIRED
--------
1. Fix patch comments.
2. Remove blank space diff.

DETAILS
-------
>       BUG#47540: Backup unit tests errors on Solaris.
>       
>       The common error is the placement of plan() at the end
>        of run_test().Tests passed when plan() is placed at the begining of
>        run_test() adhering to unit test frame work.
>       
>       In few unit tests, where number of tests to planned are not known before hand,
>       plan(NO_PLAN) was called. Whenever ok() fails, g_test.failed is incremented
> (tap.c)
>       and failed tests are reported. 

[1] Please keep comment lines to < about 70-75 characters and left align 
the lines. Watch the extra tabs, grammar, and spelling too. ;)

Do something like this:

BUG#47540: Backup unit tests errors on Solaris.

The common error is the placement of plan() at the end
of run_test(). Tests passed when plan() is placed at the
beginning of run_test() adhering to unit test frame work.

In few unit tests, where number of tests to planned are
not known before hand, plan(NO_PLAN) was called. Whenever
ok() fails, g_test.failed is incremented (tap.c) and failed
tests are reported.

...


> === modified file 'unittest/backup/bstr_random_chunks-t.c'
> --- a/unittest/backup/bstr_random_chunks-t.c	2009-10-12 09:08:34 +0000
> +++ b/unittest/backup/bstr_random_chunks-t.c	2009-11-13 15:12:39 +0000
> @@ -44,9 +44,12 @@ void run_test()
>    size_t byte_count;
>    size_t csize;
>    int    ret;
> -  uint   planned;
>  
>    stream_block_size= BSIZE;
> + /*
> +   Number of tests to be planned are not known at this point.
> +  */
> +  plan(NO_PLAN);
>  
>    diag("Writing");
>  
> @@ -62,7 +65,7 @@ void run_test()
>    for(byte_count=0 ; byte_count < DATA_AMOUNT ; )
>    {
>      csize= chunk_size[hash(CSIZE_NUM, chunk_count)];
> -
> +    

[2] Please check your patches to make sure you are not doing any blank 
space replacement (say by putting an extra space on the end of a line or 
an extra blank line or removing a line for no stated reason).

Note: This is considered by many to be a condition for rejecting a 
patch. I don't agree on that point but having had my own patches 
rejected for this I will require you to fix this before pushing.

Chuck
Thread
bzr commit into mysql-6.0-backup branch (ritheesh.vedire:2890)Bug#47540Ritheesh Vedire13 Nov
  • Re: bzr commit into mysql-6.0-backup branch (ritheesh.vedire:2890)Bug#47540Rafal Somla13 Nov
  • Re: bzr commit into mysql-6.0-backup branch (ritheesh.vedire:2890)Bug#47540Charles Bell13 Nov