Hi Chuck,
in the quoted message I forgot one important point.
Ingo Strüwing, 09.11.2009 20:00:
...
> Chuck Bell, 06.11.2009 15:47:
...
>> === modified file 'sql/backup/restore_info.h'
Another plea. Please do me the favor and don't put function definitions
in header files.
restore_info.h is (indirectly) included in a couple of sources. All
include the function definition. I guess, to make this syntactically ok,
we have the "inline" keyword on it. But I don't see, which exceptions
from the coding guidelines allow this function to be inline.
I think, there should be a restore_info.cc file, which defines
functions, declared in restore_info.h.
BTW (not from your patch), there is a circular dependency between
backup_kernel.h and restore_info.h.
Regards
Ingo
--
Ingo Strüwing, Database Group
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring HRB München 161028
