Adding commits in cc
sanjay Manwani wrote:
> Hi Chuck,
> Please see below:
> Charles Bell wrote:
>> STATUS
>> ------
>> Patch rejected.
>>
>> REQUIRED
>> --------
>> 1. Fix collateral test failures.
> I will create new result files for backup.backup_views and
> backup.backup_objects
> The only change in these is due to the default database now being
> available after restore.
> For backup.backup_events as well as SHOW CREATE see 2.
>> 2. Why is the CREATE statement different?
> This is a quirk of timing. When I run this in the debugger I get the
> error. If I do not run in the debugger there is no problem. I feel
> this is a problem with the events test.
> I would treat it in the same way as we have treated BUG#43211 - "Will
> not fix"
>>
>> REQUESTS
>> --------
>> 3. Please state the problem in the patch comments.
> I copied the comment you wanted me to put in your last rejection.
> Please tell me exactly what you want and I will put there.
>> 4. Please use correct grammar and complete sentences when possible.
> Again, I did complete the sentence. If you would like better English,
> kindly tell me the exact sentese and I will put it there.
>>
>> 5. Why are we testing this?
> It was requested by Rafal, I will delete the test if you dont want it
> there.
>> 6. Why is the indentation done this way?
> I will start the comment on the new line.
>
>
> Please let me know if you have issues with this approach.
> Regards
> Sanjay
>
