List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:November 9 2009 8:14pm
Subject:Re: bzr commit into mysql-5.1-bugteam branch
(kristofer.pettersson:3189) Bug#46043
View as plain text  
Hi Kristofer,

On 11/9/09 8:47 AM, Kristofer Pettersson wrote:
> #At file:///Users/thek/Development/mysql-5.1-bugteam/ based on
> revid:kristofer.pettersson@stripped
>
>   3189 Kristofer Pettersson	2009-11-09
>        Bug#46043 mysqld --skip-innodb does not skip InnoDB
>
>        The prefix --skip- didn't work on 64 bit big endian machines
>        because of how the value pointer was casted.
>       @ mysys/my_getopt.c
>          * Split if-statement; The value pointer must correspond to the type mask or
> it will break on big endian platforms.
>

OK to push with one request: let's re-use code and avoid a split 
if-statement for BOOL and ENUM -- instead of doing the assignment and 
cast manually, use init_one_value function.

Regards,

-- Davi Arnaut
Thread
bzr commit into mysql-5.1-bugteam branch (kristofer.pettersson:3189)Bug#46043Kristofer Pettersson9 Nov
  • Re: bzr commit into mysql-5.1-bugteam branch(kristofer.pettersson:3189) Bug#46043Davi Arnaut9 Nov