List:Commits« Previous MessageNext Message »
From:Guilhem Bichot Date:November 9 2009 7:56am
Subject:Re: bzr commit into mysql-trunk-perfschema branch (marc.alff:2944)
WL#2360
View as plain text  
Hello Marc,

Marc Alff a écrit, Le 06.11.2009 17:34:
> Hi Guilhem
> 
> Guilhem Bichot wrote:
>> Hello,
>>
>> All good, one detail (apart from the remaining INSTRUMENT_ME):
>>
> 
> The remaining INSTRUMENT_ME are placed in "example" code, see:
> 
> #ifdef TRANS_LOG_MGM_EXAMPLE_CODE
> 
> I don't think "example" or "test" code should be in the same place as
> the production code to start with, but given that it is there,
> INSTRUMENT_ME is the best change I can think of.
> 
> I am open to suggestions.

Sorry, I had not realized that the INSTRUMENT_ME tags were in 
non-compiled code. You can ignore my comment.
Thread
bzr commit into mysql-trunk-perfschema branch (marc.alff:2944) WL#2360Marc Alff6 Nov
  • Re: bzr commit into mysql-trunk-perfschema branch (marc.alff:2944)WL#2360Guilhem Bichot6 Nov
    • Re: bzr commit into mysql-trunk-perfschema branch (marc.alff:2944)WL#2360Marc Alff6 Nov
      • Re: bzr commit into mysql-trunk-perfschema branch (marc.alff:2944)WL#2360Guilhem Bichot9 Nov