Hi Ingo,
I have committed new patch now
which should address all your comments:
http://lists.mysql.com/commits/89721
Ingo Strüwing wrote:
> Hi Thava,
>
> One comment before the review: Your commit email is missing the
> "bundle". This makes it more difficult to apply your patch to a branched
> tree. Are you sure that you have the newest version of the mysql plugin?
> Currently it is on revision 169.
>
Oops. The swan machine which I used for the commit
needed an update. fixed this now.
> Status: Approved pending changes.
>
> Required:
> 1) Build with zlib and fix backup_errors_compression.result.
>
Done.
> 2) Verify that the error cannot be provoked without error injection.
>
There is no easy way of provoking this error without injection.
> 5) Add a test BACKUP DATABASE * and error injection.
>
Done.
> 6) Function header formatting.
>
>
Done.
> Options:
> 3), 4) Select different keywords for error injection.
>
>
Done.
-thava
> Details:
> Thava Alagu, 06.11.2009 07:36:
>
> ...
>
>> 2888 Thava Alagu 2009-11-06
>> BUG#47994 : Interruption of BACKUP command reported multiple times.
>>
>> When backup session is interrupted at certain stages, multiple duplicate
>> warning messages are generated.
>>
>> Added additional checks to catch interruption of the command earlier
>> to stop the backup kernel from executing further queries.
>> Removed some duplicate pushing of warnings.
>>
> ...
>
> Regards
> Ingo
>
