Hi, Luis!
On Nov 04, Luis Soares wrote:
> 3139 Luis Soares 2009-11-04
> BUG#48048: Deprecated constructs need removal in Betony
Looks ok on the cursory glance.
I presume you didn't want me to do a line-by-line comparison of this
changeset with my old changeset, so I only quickly looked it through.
One minor thing catched my eye, see below.
> NOTE: Backport of:
>
> bzr log -r revid:sp1r-serg@stripped
> ------------------------------------------------------------
> revno: 2469.263.4
> committer: serg@stripped
> timestamp: Sat 2007-05-05 13:03:19 -0700
> message:
> Removing deprecated features:
> --master-XXX command-line options
> log_bin_trust_routine_creators
> table_type
> BACKUP TABLE ...
> RESTORE TABLE ...
> SHOW PLUGIN
> LOAD TABLE ... FROM MASTER
> LOAD DATA FROM MASTER
> SHOW INNODB STATUS
> SHOW MUTEX STATUS
> SHOW TABLE TYPES
> ... TIMESTAMP(N)
> ... TYPE=engine
>
> RESET SLAVE don't reset connection parameters anymore
> LOAD DATA: check opt_secure_file_priv before access(filename)
> improved WARN_DEPRECATED macro
>
> === modified file 'mysql-test/t/type_timestamp.test'
> --- a/mysql-test/t/type_timestamp.test 2009-01-31 01:08:41 +0000
> +++ b/mysql-test/t/type_timestamp.test 2009-11-04 12:28:20 +0000
> @@ -67,9 +67,9 @@ INSERT INTO t1 VALUES ("2030-01-01","203
> SELECT * FROM t1;
> drop table t1;
>
> -create table t1 (t2 timestamp(2), t4 timestamp(4), t6 timestamp(6),
> - t8 timestamp(8), t10 timestamp(10), t12 timestamp(12),
> - t14 timestamp(14));
> +create table t1 (t2 timestamp, t4 timestamp, t6 timestamp,
> + t8 timestamp, t10 timestamp, t12 timestamp,
> + t14 timestamp);
this is not a very meaningful test now, is it ?
I'd say it'd better to remove it completely.
(you can do it in a separate changeset, no need to recommit the whole
thing)
> insert t1 values (0,0,0,0,0,0,0),
> ("1997-12-31 23:47:59", "1997-12-31 23:47:59", "1997-12-31 23:47:59",
> "1997-12-31 23:47:59", "1997-12-31 23:47:59", "1997-12-31 23:47:59",
Regards / Mit vielen Grüßen,
Sergei
--
__ ___ ___ ____ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik <serg@stripped>
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
/_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028
<___/ Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring
