List:Commits« Previous MessageNext Message »
From:Charles Bell Date:November 6 2009 2:52pm
Subject:Re: bzr commit into mysql-6.0-backup branch (charles.bell:2888)
Bug#44787
View as plain text  
Rafal,

A new patch is ready for review.

http://lists.mysql.com/commits/89608

> REQUIRED
> --------
> 1. Fix description of which privileges are checked.

Done. Shouldn't this have been a request? It seems a lack of trust to 
make it a requirement.

> 2. Report errors detected in check_restore_privileges().

Done. Test case added to show error works.

> 3. Remove redundant per database/view privilege checks.

I have given my reasons for wanting to keep the redundant check and I 
feel our discussion on Thursday made it clear this wasn't going to be an 
issue. If you insist it is, then I invoke developer privilege and will 
keep it in the patch.

> SUGGESTIONS

Being suggestions, I implemented some I felt were good and improved the 
patch and rejected the others.

Chuck
Thread
bzr commit into mysql-6.0-backup branch (charles.bell:2888) Bug#44787Chuck Bell5 Nov
  • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2888)Bug#44787Rafal Somla6 Nov
    • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2888)Bug#44787Charles Bell6 Nov