Hi Joro,
A couple of quick questions inline:
On 22.10.09 20:39, Georgi Kodinov wrote:
> === modified file 'mysql-test/t/order_by.test'
> --- a/mysql-test/t/order_by.test 2008-10-16 16:37:17 +0000
> +++ b/mysql-test/t/order_by.test 2009-10-22 16:39:31 +0000
> @@ -756,3 +756,29 @@ SELECT
> FROM t3;
>
> DROP TABLE t1, t2, t3;
> +
> +
> +
> +--echo #
> +--echo # Bug #42760: Select doesn't return desired results when we have null
> +--echo # values
> +--echo #
> +
> +CREATE TABLE t1 (
> + a INT,
> + c INT,
> + UNIQUE KEY a_c (a,c),
> + KEY (a));
> +
> +INSERT INTO t1 VALUES (1, 10), (2, NULL);
> +
> +--echo # Must use ref-or-null on the a_c index
Why?
> === modified file 'sql/sql_select.cc'
[skipped]
> --- a/sql/sql_select.cc 2009-10-21 09:04:08 +0000
> +++ b/sql/sql_select.cc 2009-10-22 16:39:31 +0000
> @@ -6336,6 +6342,7 @@ make_join_readinfo(JOIN *join, ulonglong
> break;
> default:
> DBUG_PRINT("error",("Table type %d found",tab->type)); /* purecov:
> deadcode */
> + DBUG_ASSERT (1 != 0);
Why?
> break; /* purecov: deadcode */
> case JT_UNKNOWN:
> case JT_MAYBE_REF:
> @@ -12653,6 +12660,8 @@ test_if_skip_sort_order(JOIN_TAB *tab,OR
> if (create_ref_for_key(tab->join, tab, keyuse,
> tab->join->const_table_map))
> DBUG_RETURN(0);
> +
> + pick_table_access_method(tab);
> }
> else
> {
>
>
>
>
>
Best regards,
Alexey.
