Hello,
All good, one detail (apart from the remaining INSTRUMENT_ME):
Marc Alff a écrit, Le 06.11.2009 04:14:
> #At file:///home/malff/BZR_TREE/mysql-trunk-perfschema/ based on
> revid:marc.alff@stripped
>
> 2944 Marc Alff 2009-11-05
> WL#2360 Performance Schema
>
> Completed the instrumentation for file STAT and FSTAT.
> === modified file 'sql/rpl_rli.cc'
> --- a/sql/rpl_rli.cc 2009-10-28 20:59:30 +0000
> +++ b/sql/rpl_rli.cc 2009-11-06 03:14:41 +0000
> @@ -326,7 +326,8 @@ static inline int add_relay_log(Relay_lo
> {
> MY_STAT s;
> DBUG_ENTER("add_relay_log");
> - if (!my_stat(linfo->log_file_name,&s,MYF(0)))
> + if (!mysql_file_stat(key_file_relay_log_info,
> + linfo->log_file_name, &s, MYF(0)))
The file we stat is a relay log (usually a file named
`hostname`-relay-bin.######), which carries replication events received
from the master. key_file_relay_log_info is for the file named
"relay-log.info", which carries a pointer to the slave's current read
position in the relay log. In this function, we stat all relay logs in
order to see how much total space they occupy.
Relay logs are often opened with open_binlog() which uses
key_file_binlog, so I suggest using key_file_binlog in the
mysql_file_stat() above.
> {
> sql_print_error("log %s listed in the index, but failed to stat",
> linfo->log_file_name);
