List:Commits« Previous MessageNext Message »
From:Dao-Gang.Qu Date:November 5 2009 6:07am
Subject:bzr commit into mysql-5.1-bugteam branch (Dao-Gang.Qu:3195) Bug#34739
View as plain text  
#At file:///home/daogangqu/mysql/bzrwork/bug34739/mysql-5.1-bugteam/ based on revid:timothy.smith@stripped

 3195 Dao-Gang.Qu@stripped	2009-11-05
      Bug #34739  unexpected binlog file name when --log-bin is set to a directory name
      
      If --log-bin is set to a directory name with the trailing 'FN_LIBCHAR', 
      which will be '/' on Unix like systems, and '\\' on Windows like systems. 
      the basename of the binlog is empty so that the created files named 
      '.000001' and '.index'. It is not expected. 
      The same thing happened to --log-bin-index, --relay-log and 
      --relay-log-index options.
      
      To resolve the problem, in these cases the program should report an error 
      and abort.
     @ sql/mysqld.cc
        Added a check for the value of the --log-bin and --log-bin-index arguments, 
        if it's a directory, reports an error and aborts.
     @ sql/rpl_rli.cc
        Added a check for the value of the --relay-log and --relay-log-index arguments, 
        if it's a directory, reports an error and aborts.

    modified:
      sql/mysqld.cc
      sql/rpl_rli.cc
=== modified file 'sql/mysqld.cc'
--- a/sql/mysqld.cc	2009-11-03 00:52:57 +0000
+++ b/sql/mysqld.cc	2009-11-05 06:07:31 +0000
@@ -3888,6 +3888,27 @@ server.");
 
   if (opt_bin_log)
   {
+    /* Reports an error and aborts, if the --log-bin's path 
+       is a directory.*/
+    if (opt_bin_logname && 
+        opt_bin_logname[strlen(opt_bin_logname) - 1] == FN_LIBCHAR)
+    {
+      sql_print_error("Path '%s' is a directory name, please specify \
+a file name for --log-bin option", opt_bin_logname);
+      unireg_abort(1);
+    }
+
+    /* Reports an error and aborts, if the --log-bin-index's path 
+       is a directory.*/
+    if (opt_binlog_index_name && 
+        opt_binlog_index_name[strlen(opt_binlog_index_name) - 1] 
+        == FN_LIBCHAR)
+    {
+      sql_print_error("Path '%s' is a directory name, please specify \
+a file name for --log-bin-index option", opt_binlog_index_name);
+      unireg_abort(1);
+    }
+
     char buf[FN_REFLEN];
     const char *ln;
     ln= mysql_bin_log.generate_name(opt_bin_logname, "-bin", 1, buf);

=== modified file 'sql/rpl_rli.cc'
--- a/sql/rpl_rli.cc	2009-09-23 13:21:29 +0000
+++ b/sql/rpl_rli.cc	2009-11-05 06:07:31 +0000
@@ -132,6 +132,29 @@ int init_relay_log_info(Relay_log_info* 
     rli->relay_log.max_size (and mysql_bin_log.max_size).
   */
   {
+    /* Reports an error and returns, if the --relay-log's path 
+       is a directory.*/
+    if (opt_relay_logname && 
+        opt_relay_logname[strlen(opt_relay_logname) - 1] == FN_LIBCHAR)
+    {
+      pthread_mutex_unlock(&rli->data_lock);
+      sql_print_error("Path '%s' is a directory name, please specify \
+a file name for --relay-log option", opt_relay_logname);
+      DBUG_RETURN(1);
+    }
+
+    /* Reports an error and returns, if the --relay-log-index's path 
+       is a directory.*/
+    if (opt_relaylog_index_name && 
+        opt_relaylog_index_name[strlen(opt_relaylog_index_name) - 1] 
+        == FN_LIBCHAR)
+    {
+      pthread_mutex_unlock(&rli->data_lock);
+      sql_print_error("Path '%s' is a directory name, please specify \
+a file name for --relay-log-index option", opt_relaylog_index_name);
+      DBUG_RETURN(1);
+    }
+
     char buf[FN_REFLEN];
     const char *ln;
     static bool name_warning_sent= 0;


Attachment: [text/bzr-bundle] bzr/dao-gang.qu@sun.com-20091105060731-dov4pmjebna0l6ad.bundle
Thread
bzr commit into mysql-5.1-bugteam branch (Dao-Gang.Qu:3195) Bug#34739Dao-Gang.Qu5 Nov