List:Commits« Previous MessageNext Message »
From:Charles Bell Date:November 4 2009 11:32pm
Subject:Re: bzr commit into mysql-6.0-backup branch (charles.bell:2888)
Bug#44787
View as plain text  
Ingo,

> 9) Indentation (two places).

I must apologize formally and with great humility. My development tool 
was recently updated and it seems some of the editing features have been 
set to some very bizarre settings. It seems the indentation and 
alignment of comments is especially hosed.

When I look at the code in the editor everything is fine, but when bzr 
commits a patch it's hosed. I think I have the problem corrected and I 
have checked the latest patches twice to ensure they are formatted 
correctly.

> Requests:
> 1) Improve revision comment.

Done.

> 2) Improve file comment.

Done.

> 3) Fix typo (multiple places).

Done.

> 4) Explain excessive errors.

Sorry, I cannot. They do not appear in the latest patch.

> 7) Is it *that* random, which error RESTORE will throw?

Same as (4). Sorry, it defies explanation.

> Options:
> 5) Exchange order of test paragraphs.

Accepted.

> 6) Don't disconnect/reconnect 'root' all the time.

Will consider for a later fix/patch. It would mean redoing several tests 
to make the change consistent. Perhaps this can be a bug/feature request?

> 8) We don't want to add end-space.

Again, this is my environment going wonky.

> 10) Function names.

Done.

...

Chuck
Thread
bzr commit into mysql-6.0-backup branch (charles.bell:2888) Bug#44787Chuck Bell2 Nov 2009
  • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2888)Bug#44787Ingo Strüwing4 Nov 2009
    • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2888)Bug#44787Charles Bell4 Nov 2009
      • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2888)Bug#44787Ingo Strüwing6 Nov 2009