Hi Chuck,
thank you for the answers. Please find some comments below.
Charles Bell, 03.11.2009 23:02:
> Ingo,
...
>>> +call mtr.add_suppression("Backup:");
>>> +call mtr.add_suppression("Restore:");
>>> +enable_query_log;
>>
>>
>> 3) Hema uses to ask for narrower suppressions. I concur.
>
> Sorry. Can you explain? Do you mean suppression for specific messages?
> That would be a very long list.
Yes, I meant suppression for specific messages. I don't think, the list
would be so long. If it would be, we should rethink, if it is good to
flood the error log with so many messages that a dba won't bother to
take notice of them, but make it a habit to ignore backup/restore messages.
The advantage of suppressing specific messages would be that we could
detect changes in the system that might otherwise go undetected.
...
>>> + + return check_access(thd, priv, db->name().ptr(), 0, 1, 1, 0);
>>> +}
>>> +
>>> +/**
>>
>>
>> 6) Please have two blank lines between function definitions.
>
> Is this a standard? I've never done that. I always use one (but I can
> change). ;)
http://forge.mysql.com/wiki/MySQL_Internals_Coding_Guidelines#Indentation_and_Spacing
"
* To separate two functions, use three line breaks (two empty
lines). To separate a list of variable declarations from executable
statements, use two line breaks (one empty line). For example:
int function_1()
{
int i;
int j;
function0();
}
int function2()
{
return;
}
"
Regards
Ingo
--
Ingo Strüwing, Database Group
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring HRB München 161028
