Hi Dao-Gang,
I think the sentence from the manual is a bit too long for this text,
see comment inline.
/Sven
Dao-Gang.Qu@stripped wrote:
> #At file:///home/daogangqu/mysql/bzrwork/bug34777/mysql-5.1-bugteam/ based on
> revid:dao-gang.qu@stripped
>
> 3192 Dao-Gang.Qu@stripped 2009-10-27
> Bug #34777 mysqlbinlog: --help output for --base64-output is hard to
> understand
>
> Append the description of the 'decode-rows' value for --base64-output
> argument.
>
> modified:
> client/mysqlbinlog.cc
> === modified file 'client/mysqlbinlog.cc'
> --- a/client/mysqlbinlog.cc 2009-10-20 05:16:09 +0000
> +++ b/client/mysqlbinlog.cc 2009-10-27 03:43:19 +0000
> @@ -992,11 +992,14 @@ static struct my_option my_long_options[
> /* 'unspec' is not mentioned because it is just a placeholder. */
> "Determine when the output statements should be base64-encoded BINLOG "
> "statements: 'never' disables it and works only for binlogs without "
> - "row-based events; 'auto' prints base64 only when necessary (i.e., "
> - "for row-based events and format description events); 'always' prints "
> - "base64 whenever possible. 'always' is for debugging only and should "
> - "not be used in a production system. If this argument is not given, "
> - "the default is 'auto'; if it is given with no argument, 'always' is used."
> + "row-based events; 'decode-rows' specifies to mysqlbinlog that you "
> + "intend for row events to be decoded and displayed as commented SQL "
> + "statements by also specifying the --verbose option;
This sentence is a bit cumbersome, and the bit about --verbose is not
completely clear. Perhaps a more direct way to say it is:
'decode-rows' decodes row events into commented SQL statements if the
--verbose option is also given
> 'auto' prints "
> + "base64 only when necessary (i.e., for row-based events and format "
> + "description events); 'always' prints base64 whenever possible. "
> + "'always' is for debugging only and should not be used in a production "
> + "system. If this argument is not given, the default is 'auto'; if it is "
> + "given with no argument, 'always' is used."
> ,(uchar**) &opt_base64_output_mode_str,
> (uchar**) &opt_base64_output_mode_str,
> 0, GET_STR, OPT_ARG, 0, 0, 0, 0, 0, 0},
>
>
>
> ------------------------------------------------------------------------
>
>
--
Sven Sandberg, Software Engineer
MySQL AB, www.mysql.com
