Hi Chuck,
Charles Bell, 23.10.2009 16:45:
> STATUS
> ------
> Approved.
Thank you.
>
> COMMENTARY
> ----------
> [general audience] We should strive to use 'MySQL Backup' and avoid
> using 'Online Backup' for documentation of any kind. I'd also suggest we
> correct it whenever it appears. The name of the product was changed to
> 'MySQL Backup' some time ago.
Ok. I'll try to keep it in mind.
>
> SUGGESTIONS
> -----------
> Would the test benefit from being placed in the backup_engines suite?
You mean, instead of using three engines in one test, having a test that
iterates over all engines? That's an interesting idea. But I would have
to opt out a bunch of engines. At the moment, only the three, MyISAM,
MEMORY, and InnoDB can be used with auto_increment.
Do you think it is worth the effort and time at this point in time?
...
> Is there no way to capture it at VP time and save it later?
There is a way. But it means to collect the values in the lock phase. We
want to keep that phase as short as possible. If a requirement arises
that we need to restore exact auto_increment values, then we need to
extend the lock phase.
BTW, did you check out the code around the new "/*FALLTHROUGH ...*/"
comment? Isn't there a bug?
Regards
Ingo
--
Ingo Strüwing, Database Group
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring HRB München 161028
