List:Commits« Previous MessageNext Message »
From:Alexander Nozdrin Date:October 21 2009 2:01pm
Subject:bzr commit into mysql-5.5.0-next-mr-bugfixing branch (alik:2907)
Bug#25822 WL#3953
View as plain text  
#At file:///mnt/raid/alik/MySQL/bzr/backporting/mysql-next-mr-bugfixing/ based on revid:epotemkin@stripped

 2907 Alexander Nozdrin	2009-10-21
      Backporting WL#3953 from 6.0. Original revision:
      ------------------------------------------------------------
      revno: 2476.714.9
      committer: markleith@stripped
      timestamp: Mon 2007-09-03 23:18:50 +0100
      message:
        Bug#25822 / WL#3953 - Log Access Denied errors for bad passwords in the error log
        
        Added logging of Access Denied messages on failed new connections to the 
        error log when log-warnings = 2.
        
        This allows a user to log these messages without having to incur the overhead
        of using the general query log on production systems.
      ------------------------------------------------------------

    modified:
      sql/sql_connect.cc
=== modified file 'sql/sql_connect.cc'
--- a/sql/sql_connect.cc	2009-09-30 20:10:22 +0000
+++ b/sql/sql_connect.cc	2009-10-21 14:00:58 +0000
@@ -486,6 +486,18 @@ check_user(THD *thd, enum enum_server_co
                     thd->main_security_ctx.user,
                     thd->main_security_ctx.host_or_ip,
                     passwd_len ? ER(ER_YES) : ER(ER_NO));
+  /*
+    log access denied messages to the error log when log-warnings = 2
+    so that the overhead of the general query log is not required to track
+    failed connections
+  */
+  if (global_system_variables.log_warnings > 1)
+  {
+    sql_print_warning(ER(ER_ACCESS_DENIED_ERROR),
+                      thd->main_security_ctx.user,
+                      thd->main_security_ctx.host_or_ip,
+                      passwd_len ? ER(ER_YES) : ER(ER_NO));
+  }
   DBUG_RETURN(1);
 #endif /* NO_EMBEDDED_ACCESS_CHECKS */
 }


Attachment: [text/bzr-bundle] bzr/alik@sun.com-20091021140058-v4f2jvfmp35ptmq0.bundle
Thread
bzr commit into mysql-5.5.0-next-mr-bugfixing branch (alik:2907)Bug#25822 WL#3953Alexander Nozdrin21 Oct