List:Commits« Previous MessageNext Message »
From:Bjorn Munch Date:October 20 2009 9:11am
Subject:Re: bzr commit into mysql-5.1-mtr branch (Bjorn.Munch:2849) Bug#48149
View as plain text  
On 20/10 16.35, Libing Song wrote:
>>   
> It is better to comment the logic of skipping.

Where do you mean I should comment?

> have_ssl.inc should be have_ssl_communication.inc

have_ssl_communication.inc has been renamed to have_ssl.inc in 5.1,
next-mr and trunk but 6.0-codebase has both names.  I will include
have_ssl_communication.inc when I merge this up to 6.0-codebase.

>> -my $opt_ssl_supported;
>> +our $opt_ssl_supported;
>>
> I nearly have no experiences in perl, so I can not tell anything.

That's OK, but if the patch works for you then that would help to
know. :-)

- Bjorn
Thread
bzr commit into mysql-5.1-mtr branch (Bjorn.Munch:2849) Bug#48149Bjorn Munch19 Oct
  • Re: bzr commit into mysql-5.1-mtr branch (Bjorn.Munch:2849) Bug#48149Libing Song20 Oct
    • Re: bzr commit into mysql-5.1-mtr branch (Bjorn.Munch:2849) Bug#48149Bjorn Munch20 Oct