Hi, Satya!
On Oct 13, Satya B wrote:
> 2818 Satya B 2009-10-13
> Fix for Bug #41597 - After rename of user, there are additional
> grants when grants are reapplied.
ok to push
after doing one more change.
> === modified file 'sql/sql_acl.cc'
> --- a/sql/sql_acl.cc 2009-08-28 15:51:31 +0000
> +++ b/sql/sql_acl.cc 2009-10-13 12:59:29 +0000
> @@ -2096,6 +2096,8 @@ public:
> GRANT_NAME (TABLE *form);
> virtual ~GRANT_NAME() {};
> virtual bool ok() { return privs != 0; }
> + void setUserDetails(const char *h, const char *d,
> + const char *u, const char *t);
I'm sorry, I forgot to mention this in my previous review :(
We don't use camelCase in the code, rename to, say, set_user_details.
Regards / Mit vielen Grüßen,
Sergei
--
__ ___ ___ ____ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik <serg@stripped>
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
/_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028
<___/ Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring
