bk commit into 5.0 tree (tnurnberg:1.2220) BUG#20783

[Tatjana A Nuernberg]

Below is the list of changes that have just been committed into a local
5.0 repository of tnurnberg. When tnurnberg does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2220 06/07/03 21:41:15 tnurnberg@stripped +1 -0
  Bug#20783: Valgrind uninitialised warning in test case ctype_uca
    
  Two functions have different ideas of what a string should look like;
  one of them reads memory it assumes the other one may have written.
  And "if you assume ..."
    
  We now use a more defensive variety of the assuming function, this fixes
  a warning thrown by the valgrind tool.

  sql/item_cmpfunc.cc
    1.212 06/07/03 21:41:09 tnurnberg@stripped +1 -1
    c_ptr() makes incorrect assumptions about the string we get from
    out of args[0]->val_str(&tmp); c_str_safe() is more defensive.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	tnurnberg
# Host:	salvation.intern.azundris.com
# Root:	/home/tnurnberg/mysql-5.0-release

--- 1.211/sql/item_cmpfunc.cc	2006-06-30 09:26:32 +02:00
+++ 1.212/sql/item_cmpfunc.cc	2006-07-03 21:41:09 +02:00
@@ -3303,7 +3303,7 @@
     }
   }
   null_value=0;
-  return my_regexec(&preg,res->c_ptr(),0,(my_regmatch_t*) 0,0) ? 0 : 1;
+  return my_regexec(&preg,res->c_ptr_safe(),0,(my_regmatch_t*) 0,0) ? 0 : 1;
 }