From: Sergei Golubchik
Date: October 7 2009 7:38pm
Subject: Re: bzr commit into mysql-5.1-bugteam branch (svoj:3146) Bug#47073
List-Archive: http://lists.mysql.com/commits/86059
Message-Id: <20091007193827.GA3466@janus.mylan>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit

Hi, Sergey!

On Oct 07, Sergey Vojtovich wrote:

> > >  3146 Sergey Vojtovich	2009-10-06
> > >       BUG#47073 - valgrind errs, corruption,failed repair of partition,
> > >                   low myisam_sort_buffer_size
> > >       
> > >       Repair by sort (default) or parallel repair of a MyISAM table
> > >       (doesn't matter partitioned or not) as well as bulk inserts
> > >       and enable indexes some times didn't failover to repair with
> > >       key cache.
> > >       
> > >       The problem was that after unsuccessful attempt, data file was
> > >       closed. Whereas repair with key cache requires open data file.
> > >       Fixed by reopening data file.
> > 
> > Few question.
> > 
> > Why, as bug report says, "partitioned tables get corrupted during a
> > repair table. non-partitioned tables didn't" ?
> The above statement is wrong. Provided test case successfully falls back
> to repair with key cache with pure MyISAM table, since during repair
> by sort it fails to fix first (shorter) index. The reason is larger
> number of rows.

ok
 
> > Shouldn't you remove Ingo's fix for bug#25289 ?
> > Looks like it becomes a dead code after your changes.
> I'd leave this for safety. There is still a tiny chance that we fail to
> re-open data file.

No, I don't like it.
How do you see it could happen ?
If it cannot - add an assert, if you like, but not the code to hide a
possible bug.
 
Regards / Mit vielen Grüßen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring