From: Date: June 30 2006 10:52am
Subject: bk commit into 4.1 tree (kroki:1.2519) BUG#20152
List-Archive: http://lists.mysql.com/commits/8538
X-Bug: 20152
Message-Id: <200606300852.k5U8qBsA005472@moonlight.intranet>

Below is the list of changes that have just been committed into a local
4.1 repository of tomash. When tomash does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2519 06/06/30 12:52:05 kroki@stripped +2 -0
  bug #20152: mysql_stmt_execute() overwrites parameter buffers
  
  When using a parameter bind MYSQL_TYPE_DATE in a prepared statement,
  the time part of the MYSQL_TIME buffer was written to zero in
  mysql_stmt_execute(). The param_store_date() function in libmysql.c
  worked directly on the provided buffer.
  Changed to use a copy of the buffer.

  tests/mysql_client_test.c
    1.168 06/06/30 12:52:00 kroki@stripped +53 -0
    added test for bug#20152

  libmysql/libmysql.c
    1.303 06/06/30 12:51:59 kroki@stripped +3 -4
    fix for bug #20152

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	kroki
# Host:	moonlight.intranet
# Root:	/home/tomash/src/mysql_ab/mysql-4.1-bug20152

--- 1.302/libmysql/libmysql.c	2006-04-06 10:46:21 +04:00
+++ 1.303/libmysql/libmysql.c	2006-06-30 12:51:59 +04:00
@@ -2409,10 +2409,9 @@
 
 static void store_param_date(NET *net, MYSQL_BIND *param)
 {
-  MYSQL_TIME *tm= (MYSQL_TIME *) param->buffer;
-  tm->hour= tm->minute= tm->second= 0;
-  tm->second_part= 0;
-  net_store_datetime(net, tm);
+  MYSQL_TIME tm= *((MYSQL_TIME *) param->buffer);
+  tm.hour= tm.minute= tm.second= tm.second_part= 0;
+  net_store_datetime(net, &tm);
 }
 
 static void store_param_datetime(NET *net, MYSQL_BIND *param)

--- 1.167/tests/mysql_client_test.c	2006-05-24 16:09:06 +04:00
+++ 1.168/tests/mysql_client_test.c	2006-06-30 12:52:00 +04:00
@@ -11855,6 +11855,58 @@
   mysql_stmt_close(stmt);
 }
 
+
+/*
+ Bug#20152: mysql_stmt_execute() writes to MYSQL_TYPE_DATE buffer
+ */
+static void test_bug20152()
+{
+  MYSQL_BIND bind[1];
+  MYSQL_STMT *stmt;
+  MYSQL_TIME tm;
+  int rc;
+  const char *query= "INSERT INTO t1 (f1) VALUES (?)";
+
+  myheader("test_bug20152");
+
+  memset(bind, 0, sizeof(bind));
+  bind[0].buffer_type= MYSQL_TYPE_DATE;
+  bind[0].buffer= (void*)&tm;
+
+  tm.year = 2006;
+  tm.month = 6;
+  tm.day = 18;
+  tm.hour = 14;
+  tm.minute = 9;
+  tm.second = 42;
+
+  rc= mysql_query(mysql, "DROP TABLE IF EXISTS t1");
+  myquery(rc);
+  rc= mysql_query(mysql, "CREATE TABLE t1 (f1 DATE)");
+  myquery(rc);
+
+  stmt= mysql_stmt_init(mysql);
+  rc= mysql_stmt_prepare(stmt, query, strlen(query));
+  check_execute(stmt, rc);
+  rc= mysql_stmt_bind_param(stmt, bind);
+  check_execute(stmt, rc);
+  rc= mysql_stmt_execute(stmt);
+  check_execute(stmt, rc);
+  rc= mysql_stmt_close(stmt);
+  check_execute(stmt, rc);
+  rc= mysql_query(mysql, "DROP TABLE t1");
+  myquery(rc);
+
+  if (tm.hour == 14 && tm.minute == 9 && tm.second == 42) {
+    if (!opt_silent)
+      printf("OK!");
+  } else {
+    printf("[14:09:42] != [%02d:%02d:%02d]\n", tm.hour, tm.minute, tm.second);
+    DIE_UNLESS(0==1);
+  }
+}
+
+
 /*
   Read and parse arguments and MySQL options from my.cnf
 */
@@ -12078,6 +12130,7 @@
   { "test_bug11718", test_bug11718 },
   { "test_bug12925", test_bug12925 },
   { "test_bug15613", test_bug15613 },
+  { "test_bug20152", test_bug20152 },
   { 0, 0 }
 };