bzr commit into mysql-5.1-rep+2 branch (alfranio.correia:3114) Bug#44663

[Alfranio Correia]

#At file:///home/acorreia/workspace.sun/repository.mysql/bzrwork/backport/mysql-5.1-rep%2B2/ based on revid:luis.soares@stripped

 3114 Alfranio Correia	2009-09-29
      BUG#44663 Unused replication options prevent server from starting.
      
      NOTE: Backporting the patch to next-mr.
                  
      The use of option log_slave_updates without log_bin was preventing the server
      from starting. To fix the problem, we replaced the error message and the exit
      call by a warning message.

    modified:
      sql/mysqld.cc
=== modified file 'sql/mysqld.cc'
--- a/sql/mysqld.cc	2009-09-28 23:04:20 +0000
+++ b/sql/mysqld.cc	2009-09-29 13:38:32 +0000
@@ -3819,9 +3819,8 @@ with --log-bin instead.");
   }
   if (opt_log_slave_updates && !opt_bin_log)
   {
-    sql_print_error("You need to use --log-bin to make "
+    sql_print_warning("You need to use --log-bin to make "
                     "--log-slave-updates work.");
-    unireg_abort(1);
   }
   if (!opt_bin_log)
   {
@@ -3851,11 +3850,17 @@ with --log-bin instead.");
 #ifdef HAVE_REPLICATION
   if (opt_log_slave_updates && replicate_same_server_id)
   {
-    sql_print_error("\
-using --replicate-same-server-id in conjunction with \
+    if (opt_bin_log)
+    {
+      sql_print_error("using --replicate-same-server-id in conjunction with \
 --log-slave-updates is impossible, it would lead to infinite loops in this \
 server.");
-    unireg_abort(1);
+      unireg_abort(1);
+    }
+    else
+      sql_print_warning("using --replicate-same-server-id in conjunction with \
+--log-slave-updates would lead to infinite loops in this server. However this \
+will be ignored as the --log-bin option is not defined.");
   }
 #endif
 


Attachment: [text/bzr-bundle]