From: Øystein Grøvlen
Date: September 28 2009 1:24pm
Subject: Re: bzr commit into mysql-6.0-bugfixing branch (oystein.grovlen:2838)
 Bug#47217
List-Archive: http://lists.mysql.com/commits/84859
Message-Id: <4AC0B908.4010906@sun.com>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT

Jørgen Løland wrote:
> Oystein,
> 
> The fix looks good. However, I think it would be valuable if we use 
> bugfixes to add comments to non-obvious parts of the code that the bug 
> touched.
> 
> In addition to the comments you already added to sql_select.cc, the 
> difference between the two Item_func_eq[ual] classes in item_cmpfunc.h 
> would benefit from a comment describing the different ways nulls are 
> handled.

Good point.  I will add a comment in my final patch.

> Patch approved.

Thanks,

-- 
Øystein