| List: | Commits | « Previous MessageNext Message » | |
| From: | Jørgen Løland | Date: | September 28 2009 1:02pm |
| Subject: | Re: bzr commit into mysql-6.0-bugfixing branch (oystein.grovlen:2838) Bug#47217 | ||
| View as plain text | |||
Oystein,
The fix looks good. However, I think it would be valuable if we use
bugfixes to add comments to non-obvious parts of the code that the bug
touched.
In addition to the comments you already added to sql_select.cc, the
difference between the two Item_func_eq[ual] classes in item_cmpfunc.h
would benefit from a comment describing the different ways nulls are
handled.
Patch approved.
--
Jørgen Løland
| Thread | ||
|---|---|---|
| • bzr commit into mysql-6.0-bugfixing branch (oystein.grovlen:2838)Bug#47217 | Oystein.Grovlen | 24 Sep |
| • Re: bzr commit into mysql-6.0-bugfixing branch (oystein.grovlen:2838)Bug#47217 | Jørgen Løland | 28 Sep |
| • Re: bzr commit into mysql-6.0-bugfixing branch (oystein.grovlen:2838)Bug#47217 | Øystein Grøvlen | 28 Sep |
