From: Alfranio Correia
Date: September 22 2009 6:52am
Subject: Re: bzr commit into mysql-5.1-bugteam branch (alfranio.correia:3111)
 Bug#47287
List-Archive: http://lists.mysql.com/commits/84039
Message-Id: <4AB87425.4040706@sun.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

Hi Luis,

There is a new patch available.
I've addressed all your requests.

Cheers.


Luís Soares wrote:
> Hi Alfranio,
>
>   Nice Work. Please find my review comments below. I share some
> of Zhenxing's concerns/comments and I am only putting in this
> review some of requests for clarification.
>
> STATUS
> ------
>  
>   Approved after consideration of suggestions and request for
>   clarification.
>
> REQUIRED CHANGES
> ----------------
>  n/a
>
> REQUESTS
> --------
>  
>   R1. In this test case, why do we need the slave? Couldn't this
>       test just use binlog and be filed under the 'binlog' suite?
>   
Done.
>   R2. If R1 is really needed, then why do we need to create
>       tables separately on master and slave? Why not create on
>       master and then sync_slave_with_master?
>   

> SUGGESTIONS
> -----------
>
>   S1. I would leave the check 'if(!empty())' in 'reset()'.
>   
Done.