bk commit into 5.0 tree (joerg:1.2195) BUG#18516

[Joerg Bruehe]

Below is the list of changes that have just been committed into a local
5.0 repository of joerg. When joerg does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2195 06/06/27 20:18:03 joerg@stripped +1 -0
  Revert all previous attempts to call "mysql_upgrade" during RPM upgrade.
  This finishes bug#18516, as far as "generic RPMs" are concerned.

  support-files/mysql.spec.sh
    1.143 06/06/27 20:17:58 joerg@stripped +7 -19
    Revert all previous attempts to call "mysql_upgrade" during RPM upgrade,
    there are some more aspects which need to be solved before this is possible.
    For now, just ensure the binary "mysql_upgrade" is delivered and installed.
    This finishes bug#18516, as far as "generic RPMs" are concerned.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	joerg
# Host:	trift2.
# Root:	/M50/bug20216-5.0

--- 1.142/support-files/mysql.spec.sh	2006-06-27 20:04:41 +02:00
+++ 1.143/support-files/mysql.spec.sh	2006-06-27 20:17:58 +02:00
@@ -485,25 +485,7 @@
 # Initiate databases if needed
 %{_bindir}/mysql_install_db --rpm --user=%{mysqld_user}
 
-# Upgrade databases if needed
-# This must be done as database user "root", who should be password-protected,
-# but this password is not available here.
-# So ensure the server is isolated as much as possible, and start it so that
-# passwords are not checked.
-# See the related change in the start script "/etc/init.d/mysql".
-if type mktemp >/dev/null 2>&1
-then
-  mysql_tmp_sockdir=`mktemp -dt`
-else
-  PID=$$
-  mysql_tmp_sockdir=/tmp/mysql-$PID
-  ( umask 077 ; mkdir $mysql_tmp_sockdir )
-fi
-chown %{mysqld_user}:%{mysqld_group} $mysql_tmp_sockdir
-%{_sysconfdir}/init.d/mysql start --skip-networking --skip-grant-tables
--socket=$mysql_tmp_sockdir/upgrade.sock
-%{_bindir}/mysql_upgrade --socket=$mysql_tmp_sockdir/upgrade.sock
-%{_sysconfdir}/init.d/mysql stop  --skip-networking --skip-grant-tables
-rm -fr $mysql_tmp_sockdir
+# Upgrade databases if needed would go here - but it cannot be automated yet
 
 # Change permissions again to fix any new files.
 chown -R %{mysqld_user}:%{mysqld_group} $mysql_datadir
@@ -741,6 +723,12 @@
 # itself - note that they must be ordered by date (important when
 # merging BK trees)
 %changelog 
+* Tue Jun 27 2006 Joerg Bruehe <joerg@stripped>
+
+- Revert all previous attempts to call "mysql_upgrade" during RPM upgrade,
+  there are some more aspects which need to be solved before this is possible.
+  For now, just ensure the binary "mysql_upgrade" is delivered and installed.
+
 * Thu Jun 22 2006 Joerg Bruehe <joerg@stripped>
 
 - Close a gap of the previous version by explicitly using