Jorgen,
Here is the new patch with Ingo's required changes and requests. Note:
There were two patches committed on 14 September. Please use the later
one listed here. I had a request from Rafal I (nearly) forgot to add --
changes to documentation in stream code files.
http://lists.mysql.com/commits/83215
Ingo,
> REQUIRED:
> 4) Please change 4 to 8 in the comment about time value size.
Done.
> 5) Please undo accidental indentation changes.
Ooops. Done.
> 8) Please cast to (time_t).
Right. How'd I miss that one? Thanks!
> REQUESTS:
> 1) Use thread safe function instead of gmtime().
I used gmtime_r(). That is documented as safe. I started to use
get_date() but it turns out it is only used once (NAICT) in
parse_file.cc. All other "get_date()'s" are item class functions that
use MYSQL_TIME. I have tested the patch on Mac OS X, Windows Vista
32-bit, and Ubuntu 64-bit.
> 2) Please do not use single-letter variable names.
Ok, we should add that as a requirement. I agree it is bad practice.
> 6) Please do not add space at end of line.
Another oops. I dunno how that happened -- maybe my editor did it.
> 7) Please do not use single-letter variable names.
Ditto #2.
> 9) Please keep the alignment of the structure members.
Done.
> SUGGESTIONS:
> 10) Consider to print in local time.
I cannot do this yet. The test backup_logs uses mysqlbackup to test the
vp. As such, it reads the datetime from the backup image and compares it
to the datetime in the logs. I have added a note about this to the test
file.
> COMMENTARY:
> 3) I offer to download the test archives from Pushbuild and compile the
> follow-up patch.
> -) I'm surprised, how simple the change of time format is. Thanks for
> doing it.
Thank you very much! This will save me a lot of time. I'll let you know
once we're ready for it. :))
Chuck
