List:Commits« Previous MessageNext Message »
From:Charles Bell Date:August 20 2009 7:32pm
Subject:Re: bzr commit into mysql-6.0-backup branch (charles.bell:2857) WL#4722
View as plain text  
Rafal,

Thank you for the additional suggestions. Here is my reply.

> SUGGESTIONS (additional)
> ------------------------
> 14. In case you detect problem in the test, terminate it with "die", not 
> with "exit".

I cannot because 'die' does not translate the $param that I use.

> 15. Remove from test_for_error.inc the BACKUP/RESTORE invocations which 
> will execute without errors.

No, these are warning messages and I want them included.

> 16. Consider automatic generation of the "error message" -> "error 
> number" translation table using the perror utility (I think, but am not 
> sure, that it could be done from test script as a preparation step). 
> Maintaining file error_name_to_number.inc will be a pain for us all.

I was assured the need for the file is temporary and will be fixed soon 
by BUG#46528. Thus, I will wait for the bug fix.

Chuck
Thread
bzr commit into mysql-6.0-backup branch (charles.bell:2857) WL#4722Chuck Bell9 Aug
  • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2857) WL#4722Jørgen Løland11 Aug
    • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2857) WL#4722Charles Bell20 Aug
  • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2857) WL#4722Rafal Somla17 Aug
    • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2857) WL#4722Charles Bell17 Aug
      • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2857) WL#4722Rafal Somla19 Aug
        • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2857) WL#4722Charles Bell20 Aug
          • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2857) WL#4722Rafal Somla20 Aug
          • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2857) WL#4722Rafal Somla20 Aug
            • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2857) WL#4722Charles Bell20 Aug
        • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2857) WL#4722Charles Bell20 Aug
    • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2857) WL#4722Charles Bell20 Aug
      • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2857) WL#4722Rafal Somla21 Aug
        • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2857) WL#4722Charles Bell24 Aug