List:Commits« Previous MessageNext Message »
From:Chuck Bell Date:August 6 2009 5:43pm
Subject:Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2855)
Bug#43444
View as plain text  
STATUS
------
Patch approved pending request.

REQUEST
-------
Please find the new result file I sent you for the windows test and apply that 
to the patch before pushing.

COMMENTARY
----------
I don't think the append_identifier() option is needed. This method appends ' 
marks not ` marks so if you wanted ` marks then this method won't help you. I 
changed the code to use the method and it failed miserably when I attempted to 
backup a database named 'test space' (specifically, `test space`).

DETAILS
-------
>  2855 Jorgen Loland	2009-08-06
>       BUG#43444 - RESTORE confused if image contains grants for 
>       users with certain names.
>       
>       Before, RESTORE got confused if a username or objectname 
>       (table, column etc) had to be quoted for a grant to work. 
>       E.g.: "GRANT SELECT on `db.1`.`table.1` TO ...". This was
>       Partially due to insuffiently sophisticated parsing of 
>       grant strings in the restore code, and partially because
>       these names were not quoted when GRANT was executed as
>       part of RESTORE (i.e., the server rejected the statement).
>       
>       This path removes the parsing done in the restore code as 
>       it is no longer needed, and adds backticks to all object-
>       names for GRANT statements.

...


Chuck
Thread
bzr commit into mysql-6.0-backup branch (jorgen.loland:2855) Bug#43444Jorgen Loland6 Aug
  • Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2855)Bug#43444Rafal Somla6 Aug
    • Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2855)Bug#43444Paul DuBois6 Aug
    • Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2855)Bug#43444Jørgen Løland7 Aug
  • Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2855)Bug#43444Chuck Bell6 Aug