List:Commits« Previous MessageNext Message »
From:gluh Date:June 21 2006 9:53am
Subject:bk commit into 5.1 tree (gluh:1.2200)
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of gluh. When gluh does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2200 06/06/21 14:53:40 gluh@stripped +4 -0
  after merge fixes

  sql/set_var.cc
    1.182 06/06/21 14:51:18 gluh@stripped +13 -2
    after merge fix
    use open_slow_log() instead of open_query_log() for slow query log

  sql/log.h
    1.12 06/06/21 14:51:18 gluh@stripped +4 -4
    after merge fix

  sql/log.cc
    1.217 06/06/21 14:51:18 gluh@stripped +1 -1
    use open_slow_log() instead of open_query_log() for slow query log

  mysql-test/r/partition_error.result
    1.9 06/06/21 14:51:18 gluh@stripped +2 -2
    result fix

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	gluh
# Host:	eagle.intranet.mysql.r18.ru
# Root:	/home/gluh/MySQL/Merge/5.1-kt

--- 1.216/sql/log.cc	Mon Jun 19 20:50:01 2006
+++ 1.217/sql/log.cc	Wed Jun 21 14:51:18 2006
@@ -936,7 +936,7 @@ bool LOGGER::activate_log_handler(THD* t
       if ((res= reopen_log_table(log_type)))
         goto err;
       file_log_handler->get_mysql_slow_log()->
-        open_query_log(sys_var_slow_log_path.value);
+        open_slow_log(sys_var_slow_log_path.value);
       init_slow_log(log_output_options);
       opt_slow_log= TRUE;
     }

--- 1.11/sql/log.h	Mon Jun 19 20:31:26 2006
+++ 1.12/sql/log.h	Wed Jun 21 14:51:18 2006
@@ -467,8 +467,8 @@ public:
                            CHARSET_INFO *client_cs);
   void flush();
   void init_pthread_objects();
-  MYSQL_LOG *get_mysql_slow_log() { return &mysql_slow_log; }
-  MYSQL_LOG *get_mysql_log() { return &mysql_log; }
+  MYSQL_QUERY_LOG *get_mysql_slow_log() { return &mysql_slow_log; }
+  MYSQL_QUERY_LOG *get_mysql_log() { return &mysql_log; }
 };
 
 
@@ -543,13 +543,13 @@ public:
   void init_general_log(uint general_log_printer);
   void deactivate_log_handler(THD* thd, uint log_type);
   bool activate_log_handler(THD* thd, uint log_type);
-  MYSQL_LOG *get_slow_log_file_handler()
+  MYSQL_QUERY_LOG *get_slow_log_file_handler()
   { 
     if (file_log_handler)
       return file_log_handler->get_mysql_slow_log();
     return NULL;
   }
-  MYSQL_LOG *get_log_file_handler()
+  MYSQL_QUERY_LOG *get_log_file_handler()
   { 
     if (file_log_handler)
       return file_log_handler->get_mysql_log();

--- 1.181/sql/set_var.cc	Mon Jun 19 18:32:57 2006
+++ 1.182/sql/set_var.cc	Wed Jun 21 14:51:18 2006
@@ -2602,7 +2602,7 @@ bool update_sys_var_str_path(THD *thd, s
 			     set_var *var, const char *log_ext,
 			     bool log_state, uint log_type)
 {
-  MYSQL_LOG *file_log;
+  MYSQL_QUERY_LOG *file_log;
   char buff[FN_REFLEN];
   char *res= 0, *old_value=(char *)(var ? var->value->str_value.ptr() : 0);
   bool result= 0;
@@ -2640,7 +2640,18 @@ bool update_sys_var_str_path(THD *thd, s
   var_str->value_length= str_length;
   my_free(old_value, MYF(MY_ALLOW_ZERO_PTR));
   if (file_log && log_state)
-    file_log->open_query_log(sys_var_general_log_path.value);
+  {
+    switch (log_type) {
+    case QUERY_LOG_SLOW:
+      file_log->open_slow_log(sys_var_general_log_path.value);
+      break;
+    case QUERY_LOG_GENERAL:
+      file_log->open_query_log(sys_var_general_log_path.value);
+      break;
+    default:
+      DBUG_ASSERT(0);
+    }
+  }
 
   logger.unlock();
   pthread_mutex_unlock(&LOCK_global_system_variables);

--- 1.8/mysql-test/r/partition_error.result	Fri Jun 16 01:00:47 2006
+++ 1.9/mysql-test/r/partition_error.result	Wed Jun 21 14:51:18 2006
@@ -8,7 +8,7 @@ show create table t1;
 Table	Create Table
 t1	CREATE TABLE `t1` (
   `a` int(11) DEFAULT NULL
-) ENGINE=MyISAM DEFAULT CHARSET=latin1 PARTITION BY KEY (a) 
+) ENGINE=MyISAM DEFAULT CHARSET=latin1 /*!50100 PARTITION BY KEY (a)  */
 drop table t1;
 create table t1 (a int)
 engine = innodb
@@ -21,7 +21,7 @@ show create table t1;
 Table	Create Table
 t1	CREATE TABLE `t1` (
   `a` int(11) DEFAULT NULL
-) ENGINE=InnoDB DEFAULT CHARSET=latin1 PARTITION BY LIST (a) (PARTITION p0 VALUES IN (0) ENGINE = InnoDB)
+) ENGINE=InnoDB DEFAULT CHARSET=latin1 /*!50100 PARTITION BY LIST (a) (PARTITION p0 VALUES IN (0) ENGINE = InnoDB) */
 drop table t1;
 partition by list (a)
 partitions 3
Thread
bk commit into 5.1 tree (gluh:1.2200)gluh21 Jun