List:Commits« Previous MessageNext Message »
From:Marc Alff Date:July 31 2009 5:11pm
Subject:Re: bzr commit into mysql-6.0-perfschema branch (marc.alff:3156)
WL#4876
View as plain text  
Hi Guilhem

Guilhem Bichot wrote:
> Hello Marc,
> 
> Marc Alff a écrit, Le 05.06.2009 03:46:
>> Guilhem Bichot wrote:
>>> Marc Alff a écrit, Le 04.06.2009 19:38:
>>>> Guilhem Bichot wrote:
>>>>> Marc Alff a écrit, Le 28.05.2009 23:33:
>>>>>> #At file:///home/malff/BZR-TREE/mysql-6.0-wl4876/ based on
>>>>>> revid:marc.alff@stripped
>>>>>>
>>>>>>  3156 Marc Alff    2009-05-28
>>>>>>       WL#4876 Parse options before initializing mysys

(...)

> 
> 
> Here's a tested example which does what cmd_badline.test did:
> 
> # start server with bad option, output to file
> --exec $MYSQLD_BOOTSTRAP_CMD --performance-schema-enabled=maybe >
> $MYSQLTEST_VARDIR/tmp/perfschema_options.txt 2>&1 || true
> # errors in output file can be parsed with Perl or LOAD DATA INFILE
> perl;
>     use strict;
>     use warnings;
>     my $fname= "$ENV{'MYSQLTEST_VARDIR'}/tmp/perfschema_options.txt";
>     open(FILE, "<", $fname) or die;
>     my @lines= <FILE>;
>     # those two must be in the file for the test to pass
>     my @patterns=
>       ("unknown variable 'performance-schema-enabled=maybe",
>        "Aborting");
>     foreach my $one_line (@lines)
>     {
>       foreach my $one_pattern (@patterns)
>       {
>     # print pattern, not line, to get time-independent output
>         print "Found: $one_pattern\n" if ($one_line =~ /$one_pattern/);
>       }
>     }
>     close FILE;
> EOF
> 
> The result file looks like:
> Found: unknown variable 'performance-schema-enabled=maybe
> Found: Aborting
> 
> which checks that the option caused failure as expected.
> Instead of "||true" (which I found in mysql_protocols.test), which I
> wonder whether this works under Windows, you can use "--error 7" like in
> mysqladmin.test.
> 
> And here is a tested example to test that properly spelled options in
> my.cnf are seen by mysqld:
> 1) create <testname>.cnf containing for example
> # Use default setting for mysqld processes
> !include include/default_mysqld.cnf
> 
> [mysqld.1]
> performance-schema-max-thread=318
> 
> (I took inspiration from other .cnf files in mysql-test).
> 
> 2) then <testname>.test can just be:
> select * from information_schema.GLOBAL_VARIABLES where VARIABLE_NAME =
> 'PERFORMANCE_SCHEMA_MAX_THREAD';
> (or anything you prefer: SHOW ENGINE PERFORMANCE_SCHEMA STATUS...)
> 

Thanks for the tests, they are now in mysql-azalea-perfschema.

-- Marc


Thread
bzr commit into mysql-6.0-perfschema branch (marc.alff:3156) WL#4876Marc Alff28 May
  • Re: bzr commit into mysql-6.0-perfschema branch (marc.alff:3156)WL#4876Guilhem Bichot2 Jun
    • Re: bzr commit into mysql-6.0-perfschema branch (marc.alff:3156)WL#4876Guilhem Bichot3 Jun
    • Re: bzr commit into mysql-6.0-perfschema branch (marc.alff:3156)WL#4876Marc Alff5 Jun
      • Re: bzr commit into mysql-6.0-perfschema branch (marc.alff:3156)WL#4876Guilhem Bichot5 Jun
        • Re: bzr commit into mysql-6.0-perfschema branch (marc.alff:3156)WL#4876Marc Alff5 Jun
          • Re: bzr commit into mysql-6.0-perfschema branch (marc.alff:3156)WL#4876Guilhem Bichot5 Jun
            • Re: bzr commit into mysql-6.0-perfschema branch (marc.alff:3156)WL#4876Guilhem Bichot5 Jun
            • Re: bzr commit into mysql-6.0-perfschema branch (marc.alff:3156)WL#4876Marc Alff31 Jul