List:Commits« Previous MessageNext Message »
From:Ingo Strüwing Date:July 29 2009 2:02pm
Subject:Re: bzr commit into mysql-5.1 branch (mikael:3023) Bug#46354
View as plain text  
Hi Mikael,

thanks for the explanations. Approved by me pending the comments as
promised.

Mikael Ronstrom, 29.07.2009 15:47:

> Hi,
> 
> Ingo Strüwing wrote:
>> Hi Mikael,
>>
>> Mikael Ronstrom, 23.07.2009 15:43:
>>
>> ...
>>>  3023 Mikael Ronstrom    2009-07-23
>>>       Bug#46354 Crash when using list partitioning and
>>> subpartitioning and wrong subpartition definition
>>
>>
>> Please have a comment here: 1. What was the problem, 2. how was it fixed.
...
>>> === modified file 'sql/sql_yacc.yy'
>>> --- a/sql/sql_yacc.yy    2009-07-13 17:41:43 +0000
>>> +++ b/sql/sql_yacc.yy    2009-07-23 13:43:36 +0000
>>> @@ -4242,6 +4242,12 @@ sub_part_definition:
>>>            {
>>>              LEX *lex= Lex;
>>>              partition_info *part_info= lex->part_info;
>>> +            if (part_info->use_default_subpartitions &&
>>> +                part_info->partitions.elements >= 2)
>>
>>
>> Hm. I would appreciate a comment here. I spent some time to figure out,
>> what use_default_subpartitions means. I hope, I got it right:
>>
> 
> ok will do that
...


Regards
Ingo
-- 
Ingo Strüwing, Database Group
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schröder,   Wolfgang Engels,   Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring   HRB München 161028
Thread
bzr commit into mysql-5.1 branch (mikael:3023) Bug#46354Mikael Ronstrom23 Jul
  • Re: bzr commit into mysql-5.1 branch (mikael:3023) Bug#46354Ingo Strüwing29 Jul
    • Re: bzr commit into mysql-5.1 branch (mikael:3023) Bug#46354Mikael Ronstrom29 Jul
      • Re: bzr commit into mysql-5.1 branch (mikael:3023) Bug#46354Ingo Strüwing29 Jul