List:Commits« Previous MessageNext Message »
From:Chuck Bell Date:July 27 2009 2:03pm
Subject:Re: bzr commit into mysql-5.4 branch (Rafal.Somla:2846) Bug#43322
View as plain text  
STATUS
------
Approved.

DETAILS
-------
>       Bug #43322 - Finish time of BACKUP operation not stored in backup image
>       
>       Before this patch, the finish time of BACKUP operation was reported in the
>       backup logs, but was not stored in the summary section of the backup image.
>       This was because the time was not yet stored in the Backup_info object at 
>       the time when backup image summary section was written. This patch fixes 
>       this by ensuring that:
>       
>       1) End time of backup operation is stored in Backup_info *before* backup image
>          summary is written.
>       
>       2) The times stored in backup image's summary and logged in backup logs are
> the
>          same.
>      @ mysql-test/suite/backup/t/backup_logs.test
>         Added new test case for checking that times stored in backup logs and in 
>         backup image's summary section are the same.
>      @ sql/backup/image_info.h
>         Add get_end_time() method. Move code common to get_*_time() to new
>         helper function read_time() - a counterpart of save_time().
>      @ sql/backup/kernel.cc
>         - When end of backup/restore operation is reported in Backup_info::close()
> use 
>           the end time saved in the Backup_info structure. If the end time was not
> saved 
>           before, save and use the current time.
>         - Save end time after backup of table data is complete and before the summary
> 
>           section is written.
Thread
bzr commit into mysql-5.4 branch (Rafal.Somla:2846) Bug#43322Rafal Somla27 Jul
  • Re: bzr commit into mysql-5.4 branch (Rafal.Somla:2846) Bug#43322Chuck Bell27 Jul