List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:July 19 2009 2:08pm
Subject:Re: bzr commit into mysql-5.1-bugteam branch (luis.soares:3024)
Bug#42851
View as plain text  
Hi, Davi!

On Jul 19, Davi Arnaut wrote:
> On 7/18/09 1:52 PM, Luis Soares wrote:
>>   3024 Luis Soares	2009-07-18
>>        BUG#42851: Spurious "Statement is not safe to log in statement
>>        format." warnings
>>
>>        Several warnings are printed when using statement based logging
>>        and unsafe operations are logged to the binlog. For example, this
>>        is the case for statements using LIMIT + ORDER BY PK. As a
>>        consequence, this would rapidly increase mysqld error log size,
>>        in some cases to several gigabytes, causing a maintenance
>>        nightmare.
>>
>>        This patch proposes a mechanism to selectively and voluntarily
>>        suppress warnings from mysqld error log. It adds a dynamic server
>>        variable "suppress_log_warnings", which can be used to set/reset
>>        warning filtering from mysqld error log. Its details are the
>>        following:
>
> [..]
>
> Excuse my ignore, what part of this patch can't be done by piping the
> error log through a filter script? AFAIR, its possible to have a pipe
> as a logging target.
>
> Also, wouldn't it be much simpler to just rate limit messages?

And we have --log-warnings=N switch already.

The simplest solution would be to log this "Statement is not safe to log
in statement format." only when N>0, for example.

Regards / Mit vielen Grüßen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring
Thread
bzr commit into mysql-5.1-bugteam branch (luis.soares:3024) Bug#42851Luis Soares18 Jul
  • Re: bzr commit into mysql-5.1-bugteam branch (luis.soares:3024)Bug#42851Davi Arnaut19 Jul
    • Re: bzr commit into mysql-5.1-bugteam branch (luis.soares:3024)Bug#42851Sergei Golubchik19 Jul
      • Re: bzr commit into mysql-5.1-bugteam branch (luis.soares:3024)Bug#42851Luís Soares20 Jul
        • Re: bzr commit into mysql-5.1-bugteam branch (luis.soares:3024)Bug#42851Davi Arnaut20 Jul
          • Re: bzr commit into mysql-5.1-bugteam branch (luis.soares:3024)Bug#42851Konstantin Osipov20 Jul
          • Re: bzr commit into mysql-5.1-bugteam branch (luis.soares:3024)Bug#42851Mark Leith23 Jul
    • Re: bzr commit into mysql-5.1-bugteam branch (luis.soares:3024)Bug#42851Luís Soares20 Jul