List:Commits« Previous MessageNext Message »
From:V Narayanan Date:July 17 2009 8:55am
Subject:bzr commit into mysql-5.1-bugteam branch (v.narayanan:3032)
View as plain text  
#At file:///home/narayanan/Work/mysql_checkouts/shared_repository_directory/mysql-5.1-bugteam-43572-5/ based on revid:dao-gang.qu@stripped

 3032 V Narayanan	2009-07-17 [merge]
      merging with mysql-5.0-bugteam

    modified:
      mysys/array.c
=== modified file 'mysys/array.c'
--- a/mysys/array.c	2009-02-13 16:41:47 +0000
+++ b/mysys/array.c	2009-07-17 08:55:09 +0000
@@ -32,11 +32,11 @@
   DESCRIPTION
     init_dynamic_array() initiates array and allocate space for 
     init_alloc eilements. 
-    Array is usable even if space allocation failed.
+    Array is usable even if space allocation failed, hence, the
+    function never returns TRUE.
     Static buffers must begin immediately after the array structure.
 
   RETURN VALUE
-    TRUE	my_malloc_ci() failed
     FALSE	Ok
 */
 
@@ -63,12 +63,12 @@ my_bool init_dynamic_array2(DYNAMIC_ARRA
   array->size_of_element=element_size;
   if ((array->buffer= init_buffer))
     DBUG_RETURN(FALSE);
-  if (!(array->buffer=(uchar*) my_malloc_ci(element_size*init_alloc,
-                                            MYF(MY_WME))))
-  {
+  /* 
+    Since the dynamic array is usable even if allocation fails here malloc
+    should not throw an error
+  */
+  if (!(array->buffer= (char*) my_malloc_ci(element_size*init_alloc, MYF(0))))
     array->max_element=0;
-    DBUG_RETURN(TRUE);
-  }
   DBUG_RETURN(FALSE);
 } 
 


Attachment: [text/bzr-bundle] bzr/v.narayanan@sun.com-20090717085509-fyg3jcreku58t8jt.bundle
Thread
bzr commit into mysql-5.1-bugteam branch (v.narayanan:3032)V Narayanan17 Jul