STATUS: Approved.
SUGGESTION: In patch comments explain better what is the problem being solved
and how it is solved.
Rafal
Ingo Struewing wrote:
> #At file:///home2/mydev/bzrroot/mysql-6.0-wl4771-3/ based on
> revid:ingo.struewing@stripped
>
> 2843 Ingo Struewing 2009-07-13
> WL#4771 - Online Backup: Test cross-platform compatibility
>
> Yet another attempt to get at backup image files from
> Pushbuild2 platforms. This time the collection mysql-6.0-backup.push
> is changed to save the var directories from some test runs.
>
> Also included new backup image files and updated the tests
> accordingly.
> @ mysql-test/collections/mysql-6.0-backup.push
> WL#4771 - Online Backup: Test cross-platform compatibility
> Rename var directory after tests to keep their contents.
> @ mysql-test/suite/backup/include/backup_xpfm_compat_restore.inc
> WL#4771 - Online Backup: Test cross-platform compatibility
> Added comment to explain temporary workaround.
> @ mysql-test/suite/backup/include/backup_xpfm_compat_show.inc
> WL#4771 - Online Backup: Test cross-platform compatibility
> Added SHOW CREATE TRIGGER. This turned out to be
> ignorant regarding lower_case_table_names.
> @ mysql-test/suite/backup/r/backup_xpfm_compat_backup_lctn0.result
> WL#4771 - Online Backup: Test cross-platform compatibility
> Updated test result.
> @ mysql-test/suite/backup/r/backup_xpfm_compat_backup_lctn1.result
> WL#4771 - Online Backup: Test cross-platform compatibility
> Updated test result.
> @ mysql-test/suite/backup/r/backup_xpfm_compat_backup_lctn2.result
> WL#4771 - Online Backup: Test cross-platform compatibility
> Updated test result.
> @ mysql-test/suite/backup/r/backup_xpfm_compat_restore_lctn0.result
> WL#4771 - Online Backup: Test cross-platform compatibility
> Updated test result.
> @ mysql-test/suite/backup/r/backup_xpfm_compat_restore_lctn1.result
> WL#4771 - Online Backup: Test cross-platform compatibility
> Updated test result.
> @ mysql-test/suite/backup/r/backup_xpfm_compat_restore_lctn2.result
> WL#4771 - Online Backup: Test cross-platform compatibility
> Updated test result.
> @ mysql-test/suite/backup/std_data/backup_xpfm_compat_lctn0-linux_x86.bak
> WL#4771 - Online Backup: Test cross-platform compatibility
> New backup image file from 32-bit Linux.
> @ mysql-test/suite/backup/std_data/backup_xpfm_compat_lctn1-linux_x86.bak
> WL#4771 - Online Backup: Test cross-platform compatibility
> New backup image file from 32-bit Linux.
> @ mysql-test/suite/backup/t/backup_xpfm_compat_restore_lctn0.test
> WL#4771 - Online Backup: Test cross-platform compatibility
> Added tests for the new backup image files.
> Added comments to disabled test cases.
> @ mysql-test/suite/backup/t/backup_xpfm_compat_restore_lctn1.test
> WL#4771 - Online Backup: Test cross-platform compatibility
> Added tests for the new backup image files.
> @ mysql-test/suite/backup/t/backup_xpfm_compat_restore_lctn2.test
> WL#4771 - Online Backup: Test cross-platform compatibility
> Added tests for the new backup image files.
> @ sql/sql_prepare.cc
> WL#4771 - Online Backup: Test cross-platform compatibility
> Added DBUG_PRINT.
>
...
