List:Commits« Previous MessageNext Message »
From:msvensson Date:January 9 2006 9:31am
Subject:bk commit into 4.1 tree (msvensson:1.2467) BUG#15598
View as plain text  
Below is the list of changes that have just been committed into a local
4.1 repository of msvensson. When msvensson does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2467 06/01/09 10:31:07 msvensson@neptunus.(none) +3 -0
  Bug #15598 Server crashes in specific case during setting new password
   - When acl_user->host.hostname is NULL compare it as ""

  sql/sql_acl.cc
    1.171 06/01/09 10:31:01 msvensson@neptunus.(none) +3 -2
    If acl_user->host.hostname is NULL compare it as "" 

  mysql-test/t/grant.test
    1.33 06/01/09 10:31:01 msvensson@neptunus.(none) +12 -0
    Test user with host ''

  mysql-test/r/grant.result
    1.40 06/01/09 10:31:01 msvensson@neptunus.(none) +9 -0
    Test user with host ''

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	msvensson
# Host:	neptunus.(none)
# Root:	/home/msvensson/mysql/bug15598/my41-bug15598

--- 1.170/sql/sql_acl.cc	2005-11-14 13:33:52 +01:00
+++ 1.171/sql/sql_acl.cc	2006-01-09 10:31:01 +01:00
@@ -1371,7 +1371,8 @@
 	acl_user->user && !strcmp(user,acl_user->user))
     {
       if (exact ? !my_strcasecmp(&my_charset_latin1, host,
-                                 acl_user->host.hostname) :
+                                 acl_user->host.hostname ?
+				 acl_user->host.hostname : "") :
           compare_hostname(&acl_user->host,host,host))
       {
 	DBUG_RETURN(acl_user);
@@ -3604,7 +3605,7 @@
     if (!(user=acl_user->user))
       user= "";
     if (!(host=acl_user->host.hostname))
-      host= "%";
+      host= "";
     if (!strcmp(user_name->user.str,user) &&
 	!my_strcasecmp(system_charset_info, user_name->host.str, host))
       break;

--- 1.39/mysql-test/r/grant.result	2005-11-14 13:34:59 +01:00
+++ 1.40/mysql-test/r/grant.result	2006-01-09 10:31:01 +01:00
@@ -464,3 +464,12 @@
 Grants for root@localhost
 GRANT ALL PRIVILEGES ON *.* TO 'root'@'localhost' WITH GRANT OPTION
 set names latin1;
+insert into mysql.user (host, user) values ('', 'mysqltest_7');
+flush privileges;
+set password for mysqltest_7@ = password('systpass');
+show grants for mysqltest_7@;
+Grants for mysqltest_7@
+GRANT USAGE ON *.* TO 'mysqltest_7'@'' IDENTIFIED BY PASSWORD '*2FB071A056F9BB745219D9C876814231DAF46517'
+drop user mysqltest_7@;
+show grants for mysqltest_7@;
+ERROR 42000: There is no such grant defined for user 'mysqltest_7' on host ''

--- 1.32/mysql-test/t/grant.test	2005-11-14 13:34:53 +01:00
+++ 1.33/mysql-test/t/grant.test	2006-01-09 10:31:01 +01:00
@@ -421,4 +421,16 @@
 show grants for root@localhost;
 set names latin1;
 
+#
+# Bug #15598 Server crashes in specific case during setting new password
+# - Caused by a user with host ''
+#
+insert into mysql.user (host, user) values ('', 'mysqltest_7');
+flush privileges;
+set password for mysqltest_7@ = password('systpass');
+show grants for mysqltest_7@;
+drop user mysqltest_7@;
+--error 1141
+show grants for mysqltest_7@;
+
 # End of 4.1 tests
Thread
bk commit into 4.1 tree (msvensson:1.2467) BUG#15598msvensson9 Jan