Hi, Øystein!
On Jul 10, Øystein Grøvlen wrote:
> Sergei Golubchik wrote:
>> Hi, Oystein!
>> On Jul 09, Oystein Grovlen wrote:
>>> #At file:///export/home/tmp/oysteing/mysql/mysql-azalea-1/ based on
>>> revid:alik@stripped
>>>
>>> 2843 Oystein Grovlen 2009-07-09
>>> WL#5050 Increase coverage of Field::val_xxx methods in main test
>>> suite
>> This is fine.
>> To trigger Field_blob::val_int() you can use, for example, one of
>> select 1 from t1 where blob_field;
>> select left('1234567890', blob_field) from t1;
>> or something similar. The same, I presume, will work for
>> Field_varstring::val_int().
>
> Serg,
>
> Thanks for the suggestion. Running in a debugger, I have verified
> that both statements will trigger Field_blob::val_int() and similar
> for Field_varstring::val_int(). I will update the worklog and add
> test cases.
>
> Grepping the tests, I could not find examples of neither
>
> select ... from <table> where <column>
>
> nor
>
> select left(<string>, <column>)
>
> Testing of left() seems to belong to main.func_str. Any suggestion to
> where testing of the first statement should go? main.select?
You test for Field_blob::val_int - so the test belongs to type_blob.test
no matter what sql constructs you use. Right ?
Regards / Mit vielen Grüßen,
Sergei
--
__ ___ ___ ____ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik <serg@stripped>
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
/_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028
<___/ Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring
