List:Commits« Previous MessageNext Message »
From:Vasil Dimov Date:July 10 2009 9:28am
Subject:Re: bzr commit into mysql-5.1-bugteam branch (davi:2991) Bug#21704
View as plain text  
On Thu, Jul 09, 2009 at 14:49:39 -0300, Davi Arnaut wrote:
[...]
> > I also indulged in moving the test to a separate file so it is more
> > manageable and flexible - the innodb_mysql test already takes 45 seconds
> > to complete.
> 
> innodb_mysql takes too long because of poorly crafted test cases:
> 
> endora:~/bzr/mysql-5.1-bugteam $ grep sleep mysql-test/include/mix1.inc
> --sleep 5
> --sleep 5
> --sleep 5
[...]

Yeah :(

> I'm okay with moving to a separate file, but its not a long term 
> solution either. Once we get a few hundred files, things will look as 
> bad as some larger tests.

Wrt running the whole test suite - yes, but when investigating a
particular failure it is much better to have it isolated from other
tests and to be able to run it independently of other unrelated tests.

> > I will send a new InnoDB 5.1 snapshot, containing r5488 shortly.
> >
> > Thank you!
> >
> 
> All right, thanks for your time!

Thanks for _your_ time! :)

-- 
Vasil Dimov
moc.elcaro@stripped        Software Developer @ Oracle/Innobase Oy
gro.DSBeerF@dv                Committer @ FreeBSD.org
gro.d5v@dv                    Home @ Sofia, Bulgaria

Attachment: [application/pgp-signature]
Thread
bzr commit into mysql-5.1-bugteam branch (davi:2991) Bug#21704Davi Arnaut2 Jul
  • Re: bzr commit into mysql-5.1-bugteam branch (davi:2991) Bug#21704Konstantin Osipov2 Jul
  • Re: bzr commit into mysql-5.1-bugteam branch (davi:2991) Bug#21704Vasil Dimov9 Jul
    • Re: bzr commit into mysql-5.1-bugteam branch (davi:2991) Bug#21704Davi Arnaut9 Jul
      • Re: bzr commit into mysql-5.1-bugteam branch (davi:2991) Bug#21704Vasil Dimov10 Jul