On 7/9/09 1:24 PM, Vasil Dimov wrote:
[..]
>
> I have adjusted the patch with the above suggestions and I am attaching
> it to this email, please review it and sorry for the delay!
>
> Since this patch touches solely InnoDB files, I have committed it in
> the InnoDB 5.1 repository under r5488, so it can take the normal flow of
> InnoDB changes (if it is committed directly into the BZR repository an
> extra work will have to be done later to sync both trees).
Committed, but I haven't pushed. I will just disregard the local tree.
> I also indulged in moving the test to a separate file so it is more
> manageable and flexible - the innodb_mysql test already takes 45 seconds
> to complete.
innodb_mysql takes too long because of poorly crafted test cases:
endora:~/bzr/mysql-5.1-bugteam $ grep sleep mysql-test/include/mix1.inc
--sleep 5
--sleep 5
--sleep 5
endora:~/bzr/mysql-5.1-bugteam/mysql-test $ cat t/innodb_mysql-master.opt
--innodb-lock-wait-timeout=2
I'm okay with moving to a separate file, but its not a long term
solution either. Once we get a few hundred files, things will look as
bad as some larger tests.
> I will send a new InnoDB 5.1 snapshot, containing r5488 shortly.
>
> Thank you!
>
All right, thanks for your time!
