List:Commits« Previous MessageNext Message »
From:Marc Alff Date:July 1 2009 8:18pm
Subject:bzr commit into mysql-6.0-perfschema branch (marc.alff:3191)
View as plain text  
#At file:///home/malff/BZR-TREE/mysql-6.0-perfschema/ based on revid:marc.alff@stripped

 3191 Marc Alff	2009-07-01
      
      Implemented code review comments.
      
      Always reinitialize instrumented mutexes in mysys when SAFE_MUTEX is used.
      modified:
        sql/mysqld.cc

=== modified file 'sql/mysqld.cc'
--- a/sql/mysqld.cc	2009-07-01 16:09:11 +0000
+++ b/sql/mysqld.cc	2009-07-01 20:18:36 +0000
@@ -4632,8 +4632,13 @@ int main(int argc, char **argv)
     bool need_reinit= false;
 
 #ifdef SAFE_MUTEX
-    if (safe_mutex_deadlock_detector)
-      need_reinit= true;
+    /*
+      In theory, reinitialization is only needed when the
+      value of safe_mutex_deadlock_detector changed due to startup options.
+      In practice, reinitialization is always done, for simplicity,
+      to avoid depending on the default value of safe_mutex_deadlock_detector.
+    */
+    need_reinit= true;
 #endif
 
 #ifdef HAVE_PSI_INTERFACE

Thread
bzr commit into mysql-6.0-perfschema branch (marc.alff:3191) Marc Alff1 Jul