List:Commits« Previous MessageNext Message »
From:Chuck Bell Date:July 1 2009 7:13pm
Subject:Re: bzr commit into mysql-6.0-backup branch (charles.bell:2832)
Bug#39580
View as plain text  
Rafal,

Thanks for the review. Some comments...
> SUGGESTIONS
> -----------
> 1. In tests use a user who has all rights except possibly BACKUP/RESTORE 
> so that if BACKUP/RESTORE operation is refused it is because of missing 
> BACKUP/RESTORE privileges and not for other reasons.
> 
>  CREATE USER test_user;
>  GRANT ALL ON *.* TO test_user;
>  REVOKE BACKUP,RESTORE ON *.* FROM test_user;
> 
> Then these scenarios can be tested:
>  - GRANT BACKUP/RESTORE ON *.* TO test_user;
>  - GRANT BACKUP/RESTORE ON specific_db.* TO test_user;

Done.

> 2. Test additional scenarios where an explicit list of databases (more 
> than 1) is given to BACKUP command and where RESTORE restores more than 
> one database. User has privileges for some of the databases but not for 
> others.

I will wait on this one. I think if I add it now, BUG#44787 will force a 
change. Thus, I will leave this one to BUG#44787. I have added your statements 
to that bug.

Chuck
Thread
bzr commit into mysql-6.0-backup branch (charles.bell:2832) Bug#39580Chuck Bell30 Jun
  • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2832)Bug#39580Jørgen Løland1 Jul
    • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2832)Bug#39580Chuck Bell1 Jul
  • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2832)Bug#39580Rafal Somla1 Jul
    • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2832)Bug#39580Chuck Bell1 Jul