List:Commits« Previous MessageNext Message »
From:Chuck Bell Date:July 1 2009 1:31pm
Subject:Re: bzr commit into mysql-6.0-backup branch (charles.bell:2832)
Bug#39580
View as plain text  
Jorgen,

Thanks for the comments.
> STATUS:
> -------
> Approved, but please reply to the question below
> 
> REQUIREMENTS:
> -------------
> None
> 
> OPTIONAL:
> ---------
> 1) Modify slightly wrong comment in test

Ok, will fix.

> 2) Add test for BACKUP DATABASE * for user with rights.

Ok, will add one.

> QUESTION:
> ---------
> Q1) What is EXTRA_ACL?

This was an unused ACL define that the architects agreed I could remove so that 
I would not have to extend the size of the define to a ulonglong. :) As it was, 
the original code had only 1 position left and I needed 2 (BACKUP_ACL, 
RESTORE_ACL). Good question!

> COMMENTARY:
> -----------
> Thank you for all the hard work in satisfying the reviewers. I know it's 
> been a bumpy ride on this bug...

YW. Yes, it has.

Chuck
Thread
bzr commit into mysql-6.0-backup branch (charles.bell:2832) Bug#39580Chuck Bell30 Jun
  • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2832)Bug#39580Jørgen Løland1 Jul
    • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2832)Bug#39580Chuck Bell1 Jul
  • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2832)Bug#39580Rafal Somla1 Jul
    • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2832)Bug#39580Chuck Bell1 Jul