From: Olav.Sandstaa
Date: June 24 2009 1:31pm
Subject: bzr commit into mysql-6.0-falcon-team branch (Olav.Sandstaa:2742) Bug#43490
List-Archive: http://lists.mysql.com/commits/77044
X-Bug: 43490
Message-Id: <200906241331.n5ODVkeX022159@dm-uk-02.uk.sun.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1156454735=="

--===============1156454735==
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

#At file:///home/olav/mysql/develop/falcon-elog/ based on revid:olav.sandstaa@stripped

 2742 Olav.Sandstaa@stripped	2009-06-24
      Bug #43490 Falcon internal thread terminate after throwing an instance of 'SQLError'
      
      When this error occurs MySQL terminates and all that is written to the log
      file is that there was on uncaught SQLError exception. 
      The Thread class has code for writing out the exception string but unless
      the correct debug flag is specified nothing is written to the log file.
      
      This patch changes the Thread class to use Log::fatal() for writing the
      excpetion's string so that it is more likely that it get written to the log
      before the process is terminated. The patch does not fix the problem but
      will hopefully make it easier to understand what caused this exception
      to occure.

    modified:
      storage/falcon/Thread.cpp
=== modified file 'storage/falcon/Thread.cpp'
--- a/storage/falcon/Thread.cpp	2009-03-20 19:28:10 +0000
+++ b/storage/falcon/Thread.cpp	2009-06-24 13:31:32 +0000
@@ -196,7 +196,7 @@ void Thread::thread()
 	catch (SQLException& exception)
 		{
 #ifdef FALCONDB
-		Log::log ("Thread::thread: thread %d: %s\n", threadId, exception.getText());
+		Log::fatal ("Thread::thread: thread %d: %s\n", threadId, exception.getText());
 #endif
 		release();
 		throw;
@@ -204,7 +204,7 @@ void Thread::thread()
 	catch (...)
 		{
 #ifdef FALCONDB
-		Log::log ("Thread::thread: unexpected exception, rethrowing, thread %d\n", threadId);
+		Log::fatal ("Thread::thread: unexpected exception, rethrowing, thread %d\n", threadId);
 #endif
 		release();
 		throw;


--===============1156454735==
MIME-Version: 1.0
Content-Type: text/bzr-bundle; charset="us-ascii";
	name="bzr/olav.sandstaa@stripped"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: olav.sandstaa@stripped
# target_branch: file:///home/olav/mysql/develop/falcon-elog/
# testament_sha1: 766d5bcae905a1c39ee3eea9fa7e9aa895aaf3f6
# timestamp: 2009-06-24 15:31:45 +0200
# base_revision_id: olav.sandstaa@stripped\
#   4uusdd0aef11zlp8
# 
# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWfi2LcoAAdLfgEAwWuf//1Mm
rIS////wUAVVtbB7XdnRs1td7ud73e7wlEI0aBpGCp7QSfpQBkB6nppNANqCSQE000Eap5GKYhlM
NIxkJ6TNBDCUEFM1TJtQyB6TQaNNNBoAADIMUUPUBoAADIAAAAAAkkET0BMk9DJNGUaaPKeRNADI
DRi8eZG7KuzlwG+n0+BddFUGVW36wfnE72QUdGnLSXGOf5s/UaOR5/t9yGZzsVVSjoFLpVPSurJW
ua4vtfa1I2yeLS9Ykb04xWA8frluaYzdsXzgI14aXSMapVO7MKFcIs6fTaULnzfBWfzMSjVqN3RL
YYRuaz1/1n1rxxqxlYkmo1J1NXXMhM3ceDFwa33qthdtV5GhB4bznSKIZAsWamOpkXm64fsyJtRc
IdiS6hN7MOGBfVKYD2um8nfxUCKZ6DU7n+ajwandJLswhnB1mZ7Amg5YyiyB44xJReI6BtCGa/ih
UJyHLtXGPNSnxYUniyTspXrHGGkhRF+SpIoevqwhqaKpGhY4hcImSdYWm3vQnD6lp5UNGQaFZsqZ
xJEA2nEUhx5DU5TitK5ivFgwrVNqzKds5hVBI7nK+4wOBkf7uXW8w2F5hq4uJ1cVK2fYOT6b5hh5
oQTFOlf7mYzGLEreUxKl0o1KyF6uIb42tKkndIV5m55dAQYPg0YkFe98RjYMVE4xAHGcT1DtTicx
WOVDDGKjYUhKZlNCUUTtUx4cw2RbBbOdUMfkZux5MSVnhyCDmDDHhi7vOvA8V/Y8r91g/w/rWsGY
mnX55aKbhOf11iODrPQdAiAjkfLKkSs2u3rMXc7TajvrL28e48JRIuadzspIMDuK7xTQhntLYIYs
U5WuZMI5ZLUadORAz8ulT6I2YEyEfcK2c9Y3r80HYjtr/lTsc4VeKILamocPUxiTkmHpmd+Sx8Fi
rrhd5I1lCeRTomY/EgziYd1uGXRkaISkVHgZH1J5hEvYb6mMmNeDePqgtTJxmUXM74ekvJDzhZvP
eWZax9QwViVmirCDU04av0PZPgsTW9sjz73Z1VOdMj1ZohnpvfdscG2OQP2Xzi52U5I6hbIKBShv
2f2tLoc47dE1jE0GGZic9515dqTnEmJzQ3J44YqoV4sIKj6G3GWl575xjJmoNByTiXGL+wyExluX
SKx24GKOyKOthMxf5uB+gVI9w4VVBRQ0wBl5HLcJnGUzLdnGUTXB5ZaloZSy7JuZ8zx6JvjmyGSu
HsyOcBlRFbSxfv8mw5bpVCxNQRKBi2pV0Hn1IOE6xLBeRx2YTRbcPV2ZZ9xi6BZIhLVX3n14PLFh
SV3sXbWteBu2Xy6hizTYvgpqFQkIKBeoTTPG4DgzCEmcBx8umLDhXdISKRCNoNszERKcFVUxtU9i
t1EVwwqKAYIJY9pPcPGQdWyu5hXDZ0dLwzTQW011YSJlgGhUzGnRqnlYk/jgjHmY2Wcue8tYbNHw
u5DVHQHJkyOlh1Nwlr1zFhh2OsyftvnvPSillENhGTgwViXjNddk64MKm3N6WkBXdj3UeDDXRfFo
GhAoJikpfITgMmSS7QwVjXqqnoEF4R7+FQTHqEGWQxXstwUaYaUp9NCeaKIIhFAIsisnm6ni6EwX
eALAX0S8yNhoOWMNR5odBFlC6KNEWTDKDKYed5v8H57DAWugRSDYE8VCd+dvoLitJERwLliQ5aQJ
6jtp7nFe1cpBiEuV4yCIKZVTqxjure0B+uc6HdJcYJAz1f4u5IpwoSHxbFuU


--===============1156454735==--