Re: bzr commit into mysql-5.1-bugteam branch (alfranio.correia:2914) Bug#44663

[Luís Soares]

Hi Alfranio,

  I have one comment. What should happen to:

#ifdef HAVE_REPLICATION
  if (opt_log_slave_updates && replicate_same_server_id)
  {
    sql_print_error("\
using --replicate-same-server-id in conjunction with \
--log-slave-updates is impossible, it would lead to infinite loops in
this \
server.");
    unireg_abort(1);
  }
#endif

  when --log-bin is not specified? 

  I am thinking on keeping the error and abort if opt_bin_log is set. On
the other hand, if opt_bin_log is not set, maybe print a warning based
on the message above, but stating that this option combination is
ignored because --log-bin was not used.

Regards,
Luís


On Fri, 2009-06-12 at 01:59 +0000, Alfranio Correia wrote:
> #At
> file:///home/acorreia/workspace.sun/repository.mysql/bzrwork/bug-44663/mysql-5.1-bugteam/
> based on revid:azundris@stripped
> 
>  2914 Alfranio Correia	2009-06-12
>       BUG#44663 Unused replication options prevent server from starting.
>       
>       The use of option log_slave_updates without log_bin was preventing the server
>       from starting. To fix the problem, we replaced the error message and the exit
>       call by a warning message.
> 
>     modified:
>       sql/mysqld.cc
> === modified file 'sql/mysqld.cc'
> --- a/sql/mysqld.cc	2009-05-15 12:57:51 +0000
> +++ b/sql/mysqld.cc	2009-06-12 01:58:50 +0000
> @@ -3800,9 +3800,8 @@ with --log-bin instead.");
>    }
>    if (opt_log_slave_updates && !opt_bin_log)
>    {
> -    sql_print_error("You need to use --log-bin to make "
> +    sql_print_warning("You need to use --log-bin to make "
>                      "--log-slave-updates work.");
> -    unireg_abort(1);
>    }
>    if (!opt_bin_log)
>    {
> 
-- 
Luís