On Jun 10, 2009, at 10:30 AM, Andrei Elkin wrote:
> Zhen Xing, hello.
>
> I have not completed the entire review, still I have some comments and
> open (probably just to me) issues.
>
> I would rather value 1,3 as important to fix, although not critical.
> 2 is not critical and might be the beginning of a discussion.
>
>
>
> 1. status vs variables name convention on the master:
>
> E.g Rpl_semi_sync_master_status rpl_semi_sync_master_enabled
>
> On the slave the status and the var names are in lower-case.
> I suggest to stay with the lower-case convention on either side.
> Generally about the new names arrived with the sync/2 plugin,
> I think `rplug_' or `rpl_plug_' as a prefix to denote a
> replication plugin
> would be a better choice. That would facilitate to comfortable
> selecting with `show status like `rplug_%' etc to get out stuff
> belonging to plugins, a plugin separately from "static"
> rpl_ - features.
The convention is:
System variables (SHOW VARIABLES) are all lowercase.
Status variables (SHOW STATUS) are lowercase except that the first
letter is uppercase.
Just take a look at the output from both statements to see this.
--
Paul DuBois
Sun Microsystems / MySQL Documentation Team
Madison, Wisconsin, USA
www.mysql.com
