Alfranio Correia wrote:
> Alfranio Correia wrote:
> > Hi Jasonh,
> >
> > Let me know if you have comments on my comments :).
> > I will try to finish the review tomorrow.
> > I was not able to compile the plugin by using the instructions in the
> > following web page:
> > http://dev.mysql.com/doc/refman/6.0/en/plugin-creating.html
> >
> > What should I do?
> >
> > Cheers.
> >
> Hi Jasonh,
>
> I've compiled the code and changed a little bit mtr to run the rpl-test
> cases with the semi-sync enabled.
> After running mtr, the following tests failed:
>
> rpl.rpl000017 rpl.rpl_optimize rpl.rpl_row_001 rpl.rpl_row_reset_slave
> rpl.rpl_row_show_relaylog_events rpl.rpl_server_id2 rpl.rpl_slave_status
> rpl.rpl_ssl rpl.rpl_ssl1 rpl.rpl_stm_000001
> rpl.rpl_stm_mix_show_relaylog_events rpl.rpl_stm_reset_slave
> rpl.rpl_stm_until rpl.rpl_semi_sync.
>
> It would be great if you could improve what I did and run all the tests.
> I will send my patch in a separate email.
> Note that it is far from being ready to be pushed as it is just an ugly
> hacking.
Nice try! Thanks! I have tested and analyzed the problems, will try to
get it fixed by tomorrow.
And since Lars want this feature to be pushed this week, so I'll not
consider changing the coding styles or other non-critical problem before
that.
