bk commit into 4.1 tree (igor:1.2490) BUG#18206

[igor]

Below is the list of changes that have just been committed into a local
4.1 repository of igor. When igor does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2490 06/06/13 22:38:00 igor@stripped +3 -0
  Post-review corrections of the fix for bug #18206.

  sql/opt_sum.cc
    1.48 06/06/13 22:37:56 igor@stripped +4 -2
    Post-review corrections of the fix for bug #18206.

  mysql-test/t/func_group.test
    1.34 06/06/13 22:37:56 igor@stripped +9 -0
    Added another test case for bug #18206.

  mysql-test/r/func_group.result
    1.41 06/06/13 22:37:56 igor@stripped +13 -0
    Added another test case for bug #18206.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	igor
# Host:	rurik.mysql.com
# Root:	/home/igor/mysql-4.1-opt

--- 1.47/sql/opt_sum.cc	2006-06-02 19:15:28 -07:00
+++ 1.48/sql/opt_sum.cc	2006-06-13 22:37:56 -07:00
@@ -685,8 +685,10 @@
       if (!(table->file->index_flags(idx, jdx, 0) & HA_READ_ORDER))
         return 0;
 
-        /* Check whether the index component is partial */
-      if (part->length < table->field[part->fieldnr-1]->pack_length())
+      /* Check whether the index component is partial */
+      Field *part_field= table->field[part->fieldnr-1];
+      if ((part_field->flags & BLOB_FLAG) ||
+          part->length < part_field->key_length())
         break;
 
       if (field->eq(part->field))

--- 1.40/mysql-test/r/func_group.result	2006-06-02 14:14:52 -07:00
+++ 1.41/mysql-test/r/func_group.result	2006-06-13 22:37:56 -07:00
@@ -940,3 +940,16 @@
 id	select_type	table	type	possible_keys	key	key_len	ref	rows	Extra
 1	SIMPLE	t1	ALL	NULL	NULL	NULL	NULL	2	
 DROP TABLE t1;
+CREATE TABLE t1 (id int , b varchar(512), INDEX(b(250))) COLLATE latin1_bin;
+Warnings:
+Warning	1246	Converting column 'b' from CHAR to TEXT
+INSERT INTO t1 VALUES
+(1,CONCAT(REPEAT('_', 250), "qq")), (1,CONCAT(REPEAT('_', 250), "zz")),
+(1,CONCAT(REPEAT('_', 250), "aa")), (1,CONCAT(REPEAT('_', 250), "ff"));
+SELECT MAX(b) FROM t1;
+MAX(b)
+__________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________zz
+EXPLAIN SELECT MAX(b) FROM t1;
+id	select_type	table	type	possible_keys	key	key_len	ref	rows	Extra
+1	SIMPLE	t1	ALL	NULL	NULL	NULL	NULL	4	
+DROP TABLE t1;

--- 1.33/mysql-test/t/func_group.test	2006-06-02 14:14:52 -07:00
+++ 1.34/mysql-test/t/func_group.test	2006-06-13 22:37:56 -07:00
@@ -617,4 +617,13 @@
 EXPLAIN SELECT MAX(b) FROM t1;
 DROP TABLE t1;
 
+CREATE TABLE t1 (id int , b varchar(512), INDEX(b(250))) COLLATE latin1_bin;
+INSERT INTO t1 VALUES
+  (1,CONCAT(REPEAT('_', 250), "qq")), (1,CONCAT(REPEAT('_', 250), "zz")),
+  (1,CONCAT(REPEAT('_', 250), "aa")), (1,CONCAT(REPEAT('_', 250), "ff"));
+
+SELECT MAX(b) FROM t1;
+EXPLAIN SELECT MAX(b) FROM t1;
+DROP TABLE t1;
+
 # End of 4.1 tests