* Kristofer Pettersson <Kristofer.Pettersson@stripped> [09/05/29 13:07]:
>> 2) Instead of removing the call to my_error(), use push_warning()
>> extend the scope of the pushed internal error handler here:
>
> I don't agree. There is no added customer value in adding this randomly
> selected warning in this context. The user is only interested if the
> implicit convenience operation of no significant importance was
> successful or not. In fact, adding more information than necessary will
> project the illusion that something important happened.
>
> I think less is more in this case.
OK. In that case, next time (since the patch is pushed already),
please add a comment in the code with that rationale. Next person
looking at that code might find it counter-intuitive (like I did),
and try to add push_warning().
--
